[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-pim
Subject: Re: [Kde-pim] Review Request 109250: Fetch missing body parts in the IMAP resource. Part 3/3
From: "Andras Mantia" <amantia () kde ! org>
Date: 2013-03-03 10:11:04
Message-ID: 20130303101104.29936.52098 () vidsolbach ! de
[Download RAW message or body]
> On March 3, 2013, 9:34 a.m., Kevin Ottens wrote:
> > resources/imap/imapresource.cpp, line 156
> > <http://git.reviewboard.kde.org/r/109250/diff/1/?file=116628#file116628line156>
> >
> > Just wondering, why is the extra session needed?
If we don't do that, we actually run in a deadlock. ImapResource::retrieveItems \
creates an ItemSyncJob by the way of setItemStreamingEnabled( true ); call. That \
will block our fetch job, so the fetch will not run, just wait, resulting in the \
resource not working. There are other solutions, but with Volker we more or less \
decided a new session is a safe and clean enough solution.
- Andras
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109250/#review28425
-----------------------------------------------------------
On March 3, 2013, 10:04 a.m., Andras Mantia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109250/
> -----------------------------------------------------------
>
> (Updated March 3, 2013, 10:04 a.m.)
>
>
> Review request for KDEPIM, Kevin Ottens and Volker Krause.
>
>
> Description
> -------
>
> This part makes sure the IMAP resources caches the full body if it was missing for \
> whatever reason from the cache. This covers the transition from an online IMAP \
> account to a disconnected one, and also fixes the cache if it was corrupted (as it \
> happened in any KDE < master so far on account removal).
>
> Diffs
> -----
>
> resources/imap/imapresource.h 078d202
> resources/imap/imapresource.cpp 9471eb3
> resources/imap/resourcetask.h 3893a5d
> resources/imap/retrieveitemstask.h 672171a
> resources/imap/retrieveitemstask.cpp cf96dc8
>
> Diff: http://git.reviewboard.kde.org/r/109250/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andras Mantia
>
>
_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic