[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-pim
Subject: Re: [Kde-pim] Review Request 109250: Fetch missing body parts in the IMAP resource. Part 3/3
From: "Kevin Krammer" <krammer () kde ! org>
Date: 2013-03-03 10:05:47
Message-ID: 20130303100547.28990.75850 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109250/#review28426
-----------------------------------------------------------
resources/imap/imapresource.cpp
<http://git.reviewboard.kde.org/r/109250/#comment21216>
trailing whitespace
resources/imap/retrieveitemstask.cpp
<http://git.reviewboard.kde.org/r/109250/#comment21227>
Position of * at variable
resources/imap/retrieveitemstask.cpp
<http://git.reviewboard.kde.org/r/109250/#comment21228>
trailing whitespace
resources/imap/retrieveitemstask.cpp
<http://git.reviewboard.kde.org/r/109250/#comment21229>
IMHO it would be preferable to have a longer line than this line break
resources/imap/retrieveitemstask.cpp
<http://git.reviewboard.kde.org/r/109250/#comment21230>
const Akonadi::Item::List?
resources/imap/retrieveitemstask.cpp
<http://git.reviewboard.kde.org/r/109250/#comment21231>
trailing whitespace
resources/imap/retrieveitemstask.cpp
<http://git.reviewboard.kde.org/r/109250/#comment21232>
trailing whitespace
resources/imap/retrieveitemstask.cpp
<http://git.reviewboard.kde.org/r/109250/#comment21235>
is this on the same column as fetch?
resources/imap/retrieveitemstask.cpp
<http://git.reviewboard.kde.org/r/109250/#comment21236>
trailing whitespace
resources/imap/retrieveitemstask.cpp
<http://git.reviewboard.kde.org/r/109250/#comment21237>
trailing whitespace
resources/imap/retrieveitemstask.cpp
<http://git.reviewboard.kde.org/r/109250/#comment21238>
space before m_fetchedMissingBodies
resources/imap/retrieveitemstask.cpp
<http://git.reviewboard.kde.org/r/109250/#comment21239>
trailing whitespace
resources/imap/retrieveitemstask.cpp
<http://git.reviewboard.kde.org/r/109250/#comment21240>
no reset in error case?
- Kevin Krammer
On March 3, 2013, 10:04 a.m., Andras Mantia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109250/
> -----------------------------------------------------------
>
> (Updated March 3, 2013, 10:04 a.m.)
>
>
> Review request for KDEPIM, Kevin Ottens and Volker Krause.
>
>
> Description
> -------
>
> This part makes sure the IMAP resources caches the full body if it was missing for \
> whatever reason from the cache. This covers the transition from an online IMAP \
> account to a disconnected one, and also fixes the cache if it was corrupted (as it \
> happened in any KDE < master so far on account removal).
>
> Diffs
> -----
>
> resources/imap/imapresource.h 078d202
> resources/imap/imapresource.cpp 9471eb3
> resources/imap/resourcetask.h 3893a5d
> resources/imap/retrieveitemstask.h 672171a
> resources/imap/retrieveitemstask.cpp cf96dc8
>
> Diff: http://git.reviewboard.kde.org/r/109250/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andras Mantia
>
>
_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic