'Re: [Kde-pim] Review Request: Reduce the issues found by krazy2, all directories kdepim-runtime/reso'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: Reduce the issues found by krazy2, all directories kdepim-runtime/reso
From:       "Kevin Ottens" <ervin () kde ! org>
Date:       2012-04-23 21:34:21
Message-ID: 20120423213421.4110.76315 () vidsolbach ! de
[Download RAW message or body]

> On April 19, 2012, 6:05 p.m., Kevin Krammer wrote:
> > resources/imap/addcollectiontask.cpp, line 67
> > <http://git.reviewboard.kde.org/r/104672/diff/1/?file=58073#file58073line67>
> > 
> > I am not sure about those debug area changes.
> > While that area code is for the imap library and this is not library code, the \
> > IMAP resource developers might want to have those debug statements in the same \
> > area

Yes, they've been added intentionally. It falls in the false positive department from \
my perspective.

> On April 19, 2012, 6:05 p.m., Kevin Krammer wrote:
> > resources/imap/changecollectiontask.cpp, line 130
> > <http://git.reviewboard.kde.org/r/104672/diff/1/?file=58075#file58075line130>
> > 
> > better variable name?

Definitely needs a better name.

> On April 19, 2012, 6:05 p.m., Kevin Krammer wrote:
> > resources/imap/addcollectiontask.cpp, line 115
> > <http://git.reviewboard.kde.org/r/104672/diff/1/?file=58073#file58073line115>
> > 
> > maybe more verbose variable name

Needs a better name indeed.

- Kevin

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104672/#review12664
-----------------------------------------------------------

On April 19, 2012, 4:37 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104672/
> -----------------------------------------------------------
> 
> (Updated April 19, 2012, 4:37 p.m.)
> 
> 
> Review request for KDEPIM and Kevin Krammer.
> 
> 
> Description
> -------
> 
> Taking a look to
> http://www.englishbreakfastnetwork.org/krazy/reports/kde-4.x/kdepim-runtime/resources/index.html
>  
> one can see: kdepim-runtime as still more than 600 issues.
> 
> I propose to reduce this with this bugfix. 
> Thanks to Kevin for the very usefull hints of tippos such as:
> old: if(condition){
> new: if ( condition ) {
> 
> 
> Diffs
> -----
> 
> resources/birthdays/configdialog.cpp 5f1e345 
> resources/contacts/contactsresource.cpp 547e9c9 
> resources/dav/common/davcollectionmodifyjob.cpp 64cb534 
> resources/dav/common/davprincipalsearchjob.cpp 1f79f3e 
> resources/dav/resource/replaycache.h 65384bb 
> resources/imap/addcollectiontask.cpp 81c7dd9 
> resources/imap/additemtask.cpp 904046b 
> resources/imap/changecollectiontask.cpp 727f004 
> resources/imap/changeitemtask.cpp a5a09ec 
> resources/imap/expungecollectiontask.cpp 640caaf 
> resources/imap/imapidlemanager.cpp 32a37d4 
> resources/imap/imapresource.cpp 441fac9 
> resources/imap/moveitemtask.cpp 2bab48e 
> resources/imap/removecollectionrecursivetask.cpp d51eace 
> resources/imap/removecollectiontask.cpp 552da02 
> resources/imap/resourcetask.cpp a573cc5 
> resources/imap/retrievecollectionmetadatatask.cpp 7f8f7e8 
> resources/imap/retrievecollectionstask.cpp 658ba80 
> resources/imap/retrieveitemstask.cpp 16fab79 
> resources/imap/retrieveitemtask.cpp 035f279 
> resources/imap/sessionuiproxy.h b5fea7b 
> resources/imap/settingspasswordrequester.h a845513 
> resources/imap/setupserver.cpp e7d3a5a 
> resources/imap/subscriptiondialog.cpp dd369a0 
> resources/imap/tests/dummypasswordrequester.cpp 9574c50 
> resources/imap/tests/imaptestbase.h 141c739 
> resources/imap/tests/testaddcollectiontask.cpp f356401 
> resources/imap/tests/testadditemtask.cpp ebd74ba 
> resources/imap/tests/testchangecollectiontask.cpp fd191d8 
> resources/imap/tests/testchangeitemtask.cpp ab079c2 
> resources/imap/tests/testexpungecollectiontask.cpp 1cb95f2 
> resources/imap/tests/testmovecollectiontask.cpp fc6801c 
> resources/imap/tests/testmoveitemtask.cpp e0950da 
> resources/imap/tests/testremovecollectiontask.cpp 9a3152a 
> resources/imap/tests/testremoveitemtask.cpp 531a1ad 
> resources/imap/tests/testresourcetask.cpp e5671b1 
> resources/imap/tests/testretrievecollectionmetadatatask.cpp 3db7ab9 
> resources/imap/tests/testretrievecollectionstask.cpp 2a3ce35 
> resources/imap/tests/testretrieveitemstask.cpp fffd7e9 
> resources/imap/tests/testretrieveitemtask.cpp f2e3323 
> resources/imap/tests/testsessionpool.cpp 318c5f2 
> resources/kabc/kabcresource.cpp 52e97f6 
> resources/kabc/kresourceassistant.cpp e62ac93 
> resources/kalarm/kalarm/kalarmresource.h f581cad 
> resources/kalarm/kalarm/kalarmresource.cpp 4fcc84f 
> resources/kalarm/kalarmdir/kalarmdirresource.cpp 8f47e99 
> resources/kalarm/kalarmdir/settingsdialog.h 0ff4bc9 
> resources/kalarm/kalarmdir/settingsdialog.cpp d9583e5 
> resources/kalarm/shared/alarmtyperadiowidget.cpp a2fca20 
> resources/kalarm/shared/alarmtypewidget.cpp 343ff3c 
> resources/kalarm/shared/kalarmresourcecommon.h f095c37 
> resources/kalarm/shared/kalarmresourcecommon.cpp 4d38865 
> resources/kcal/kcalresource.cpp 0ffa9ec 
> resources/knut/knutresource.cpp 9a4bb34 
> resources/kolabproxy/addressbookhandler.cpp 1a3b0b9 
> resources/kolabproxy/contact.cpp e421629 
> resources/kolabproxy/freebusyupdatehandler.cpp 3b182c2 
> resources/kolabproxy/incidencehandler.cpp 548842b 
> resources/kolabproxy/journalhandler.cpp b2e54fb 
> resources/kolabproxy/kolabhandler.cpp aff972f 
> resources/kolabproxy/kolabproxyresource.cpp 0b4b5b4 
> resources/kolabproxy/notehandler.cpp 44471fd 
> resources/kolabproxy/setupdefaultfoldersjob.cpp 00efa71 
> resources/kolabproxy/setupkolab.cpp 6ef5ec9 
> resources/kolabproxy/tests/kolabconvertertest.cpp b0d3a1f 
> resources/localbookmarks/localbookmarksresource.cpp 50dcba7 
> resources/mailtransport_dummy/configdialog.cpp f51eb66 
> resources/mailtransport_dummy/mtdummyresource.cpp 192874a 
> resources/mbox/mboxresource.cpp 667468e 
> resources/microblog/configdialog.cpp 7cbbe70 
> resources/mixedmaildir/configdialog.cpp f3dd967 
> resources/mixedmaildir/kmindexreader/kmindexreader.cpp c28d656 
> resources/mixedmaildir/kmindexreader/tests/testidxreader.cpp 20c1552 
> resources/mixedmaildir/mixedmaildirresource.cpp a345dc8 
> resources/mixedmaildir/mixedmaildirstore.cpp 85711d1 
> resources/mixedmaildir/tests/collectiondeletetest.cpp 841bd2f 
> resources/mixedmaildir/tests/collectionfetchtest.cpp 7c5f6af 
> resources/mixedmaildir/tests/collectionmodifytest.cpp b9a1afb 
> resources/nntp/configdialog.cpp 511ce12 
> resources/nntp/nntpresource.cpp 1cff03b 
> resources/nntp/settings.cpp 793ba42 
> resources/openxchange/configdialog.cpp a30eab4 
> resources/openxchange/openxchangeresource.cpp 8624955 
> resources/openxchange/oxa/oxutils.cpp 6604dc3 
> resources/pop3/accountdialog.cpp 2aa7b34 
> resources/pop3/pop3resource.cpp 3910f32 
> resources/pop3/settings.cpp 3f1eb4a 
> resources/shared/collectionannotationsattribute.cpp b4df346 
> resources/shared/imapaclattribute.cpp ebd8f47 
> resources/shared/imapquotaattribute.cpp 1747c03 
> 
> Diff: http://git.reviewboard.kde.org/r/104672/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

[prev in list] [next in list] [prev in thread] [next in thread] 