[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: compact printing style for kaddressboook
From:       "Allen Winter" <winter () kde ! org>
Date:       2012-02-05 15:03:03
Message-ID: 20120205150303.16124.38256 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103868/#review10351
-----------------------------------------------------------


In general looks really good.  You are missing tooltips and whatsthis for the options \
in the .ui file.   btw, do you have commit account yet?  If not, maybe you should \
consider getting one.

- Allen Winter


On Feb. 5, 2012, 8:34 a.m., Mario Scheel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103868/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2012, 8:34 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Add a new printing style to kaddressbook. Its generate a list of contacts. See also \
> https://bugs.kde.org/show_bug.cgi?id=290438. Its a better solution. 
> This patch allows customize the list, the fields are selectable, the colors also.
> 
> 
> Diffs
> -----
> 
> kaddressbook/CMakeLists.txt a96c8306e767e7689459cd226dbd5ed19b683a76 
> kaddressbook/printing/compactstyle.h PRE-CREATION 
> kaddressbook/printing/compactstyle.cpp PRE-CREATION 
> kaddressbook/printing/compactstyle.ui PRE-CREATION 
> kaddressbook/printing/pictures/CMakeLists.txt \
> 43f6cb069c533f06fa9623ce02beb36422001e02  \
> kaddressbook/printing/pictures/compact-style.png PRE-CREATION  \
> kaddressbook/printing/printingwizard.cpp f6f7fbe54b9311c18f99ea2c55d603884ee48a98  
> Diff: http://git.reviewboard.kde.org/r/103868/diff/diff
> 
> 
> Testing
> -------
> 
> It compiles and do that I want.
> 
> 
> Thanks,
> 
> Mario Scheel
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]