[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    [Kde-pim] Re: Review Request: New NoteUtils namespace with
From:       "Christian Mollekopf" <chrigi_1 () fastmail ! fm>
Date:       2011-07-26 16:18:20
Message-ID: 20110726161820.29304.84029 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102076/
-----------------------------------------------------------

(Updated July 26, 2011, 4:18 p.m.)


Review request for Akonadi, KDEPIM-Libraries and Stephen Kelly.


Changes
-------

Check the pointer before using it, return Qt::TextFormat, indentation, includes


Summary
-------

NoteMessageWrapper is a convenience class to assemble/disassemble Kmime messages into \
notes(text message). This is a first step to standardize how notes are handled with \
akonadi/akonotes resource.

The class will be used by the upcoming akonotes-nepomuk-feeder as well as MindMirror.
(Of course also kjots and any other app working with the akonotes resource might make \
use of it)

I put the files in a new notes directory, so we can put there future efforts like an \
even more convenient Note class, which I briefly discussed with skelly.

The NoteUtils namespace can be used for further note related helper \
functions/classes.

As skelly already had a look at it I will commit if noone objects within the next \
days.


Diffs (updated)
-----

  akonadi/notes/noteutils.cpp PRE-CREATION 
  KdepimLibsConfig.cmake.in 3615dd71cf7eeba90d99ac0006c64075cdf38e38 
  akonadi/CMakeLists.txt cf63a0db5d7139d29cad268cd7aeaaa9a00e3cf1 
  akonadi/notes/CMakeLists.txt PRE-CREATION 
  akonadi/notes/akonadi-notes_export.h PRE-CREATION 
  akonadi/notes/noteutils.h PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/102076/diff


Testing
-------


Thanks,

Christian

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]