[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-pim
Subject: [Kde-pim] Re: Review Request: New NoteUtils namespace with
From: "Kevin Krammer" <kevin.krammer () gmx ! at>
Date: 2011-07-26 15:41:58
Message-ID: 20110726154158.25817.32435 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102076/#review5118
-----------------------------------------------------------
akonadi/notes/noteutils.h
<http://git.reviewboard.kde.org/r/102076/#comment4603>
in case you have this for Qt::TextFormat, I think including qnamespace.h would be \
better
akonadi/notes/noteutils.h
<http://git.reviewboard.kde.org/r/102076/#comment4604>
no need for explicit here. explicit is only applicable to constructors that can \
be called with a single argument, i.e. having one argument or having default values \
so passing only one is sufficient.
akonadi/notes/noteutils.h
<http://git.reviewboard.kde.org/r/102076/#comment4605>
maybe make this return the Qt::TextFormat, for consistency
akonadi/notes/noteutils.cpp
<http://git.reviewboard.kde.org/r/102076/#comment4609>
I wasn't commenting on the call to subject (that might have been OK), but the \
smart pointer dereferencing.
I am pretty sure that boost::shared_ptr does not create objects of its type T \
when its default constructor is called, thus operator::-> would not return a pointer \
to a message object.
You can probably check that when creating the private class' instance so you \
don't have to repeat it when filling the members here
- Kevin
On July 26, 2011, 3:20 p.m., Christian Mollekopf wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102076/
> -----------------------------------------------------------
>
> (Updated July 26, 2011, 3:20 p.m.)
>
>
> Review request for Akonadi, KDEPIM-Libraries and Stephen Kelly.
>
>
> Summary
> -------
>
> NoteMessageWrapper is a convenience class to assemble/disassemble Kmime messages \
> into notes(text message). This is a first step to standardize how notes are handled \
> with akonadi/akonotes resource.
> The class will be used by the upcoming akonotes-nepomuk-feeder as well as \
> MindMirror. (Of course also kjots and any other app working with the akonotes \
> resource might make use of it)
> I put the files in a new notes directory, so we can put there future efforts like \
> an even more convenient Note class, which I briefly discussed with skelly.
>
> The NoteUtils namespace can be used for further note related helper \
> functions/classes.
> As skelly already had a look at it I will commit if noone objects within the next \
> days.
>
> Diffs
> -----
>
> akonadi/notes/noteutils.cpp PRE-CREATION
> KdepimLibsConfig.cmake.in 3615dd71cf7eeba90d99ac0006c64075cdf38e38
> akonadi/CMakeLists.txt cf63a0db5d7139d29cad268cd7aeaaa9a00e3cf1
> akonadi/notes/CMakeLists.txt PRE-CREATION
> akonadi/notes/akonadi-notes_export.h PRE-CREATION
> akonadi/notes/noteutils.h PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/102076/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Christian
>
>
_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic