[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: Replicate original parsed message
From:       "Volker Krause" <vkrause () kde ! org>
Date:       2010-06-28 8:00:38
Message-ID: 20100628080038.1474.63239 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4457/#review6308
-----------------------------------------------------------

Ship it!


looks good to me

- Volker


On 2010-06-25 17:31:36, Leo Franchi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4457/
> -----------------------------------------------------------
> 
> (Updated 2010-06-25 17:31:36)
> 
> 
> Review request for KDE PIM and Thomas McGuire.
> 
> 
> Summary
> -------
> 
> When parsing multipart-mixed MIME objects, KMime discards the preamble and \
> epilogue. This is totally fine with regard to RFC2046, as they are optional and can \
> be ignored. However, the simple act of reading messages with either of these two \
> features modifies them, by stripping the epilogue/preamble. This makes \
> cryptographically verifying embedded messages impossible, as they are modified by \
> KMime. 
> With this patch, KMime will *only* generate a preamble or epilogue if it found one \
> when parsing, in order to mirror the original mail more accurately. 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdepimlibs/kmime/kmime_content.cpp 1142721 
> /trunk/KDE/kdepimlibs/kmime/kmime_content_p.h 1142721 
> /trunk/KDE/kdepimlibs/kmime/kmime_parsers.cpp 1142721 
> /trunk/KDE/kdepimlibs/kmime/tests/auto/contenttest.cpp 1142721 
> 
> Diff: http://reviewboard.kde.org/r/4457/diff
> 
> 
> Testing
> -------
> 
> Modified unit tests to test both cases.
> 
> 
> Thanks,
> 
> Leo
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]