[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: Fix Incidence::operator== when there
From:       "Sergio Martins" <iamsergio () gmail ! com>
Date:       2010-06-27 0:03:27
Message-ID: 20100627000327.22861.56165 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/821/#review6297
-----------------------------------------------------------


In case of a list of incidences, it will only compare the base class.

- Sergio


On 2009-06-13 12:02:53, Sergio Martins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/821/
> -----------------------------------------------------------
> 
> (Updated 2009-06-13 12:02:53)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> If you have two identical incidences with attachments Incidence::operator== will \
> return false. 
> This happens because we are comparing two ListBase object (attachments() == \
> i2.attachments()). 
> ListBase holds items of class <T> but it's derived from QList<T*>, so when you \
> compare two ListBases, QList<T*>::operator== get's called, and it compares \
> addresses instead of values. 
> I implemented ListBase::operator== so we compare values.
> 
> 
> Diffs
> -----
> 
> trunk/KDE/kdepimlibs/kcal/attachment.h 979860 
> trunk/KDE/kdepimlibs/kcal/attachment.cpp 979860 
> trunk/KDE/kdepimlibs/kcal/listbase.h 979860 
> trunk/KDE/kdepimlibs/kcal/tests/testattachment.cpp 979860 
> 
> Diff: http://reviewboard.kde.org/r/821/diff
> 
> 
> Testing
> -------
> 
> Compared attachments.
> 
> 
> Thanks,
> 
> Sergio
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]