[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: Add support to backup a PostgreSQL
From:       "Brian DeRocher" <brian () derocher ! org>
Date:       2010-03-23 1:57:43
Message-ID: 20100323015743.20493.46573 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3350/
-----------------------------------------------------------

(Updated 2010-03-23 01:57:43.000269)


Review request for KDE PIM.


Changes
-------

Added a link to my trac site which describes this diff in smaller commits.


Summary (updated)
-------

Created derived classes BackupMySQL and BackupPostgreSQL of Backup.  Most of work \
remains in Backup.  Required executables becomes a set of strings.  Derived classes \
may append to the set.  MySQL uses mysqldump.  PG uses pg_dump.  Global was updated \
to parse either a MySQL or PostgreSQL section.  BackupAssistant will create the \
proper derived class object.

This patch is broken down into a series of smaller patches which may be easier to \
review.  It's located here https://derocher.org/kde/trac/changeset/31 It goes up to \
revision 43.


This addresses bug 227970.
    https://bugs.kde.org/show_bug.cgi?id=227970


Diffs
-----

  trunk/KDE/kdepim/runtime/tray/CMakeLists.txt 1105514 
  trunk/KDE/kdepim/runtime/tray/backup.h 1105514 
  trunk/KDE/kdepim/runtime/tray/backup.cpp 1105514 
  trunk/KDE/kdepim/runtime/tray/backupassistant.cpp 1105514 
  trunk/KDE/kdepim/runtime/tray/global.h 1105514 
  trunk/KDE/kdepim/runtime/tray/global.cpp 1105514 

Diff: http://reviewboard.kde.org/r/3350/diff


Testing
-------

Successfully backed up a PostgreSQL database.  I did not test MySQL.


Thanks,

Brian

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]