[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: adds kmail support for RFC2369,
From:       "Thomas McGuire" <mcguire () kde ! org>
Date:       2009-10-28 16:20:48
Message-ID: 20091028162048.29607.43724 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1768/#review2843
-----------------------------------------------------------

Ship it!


Ok, I've finally committed this in r1041839.

Sorry that we had to go through so many iterations, but I think in the end that payed \
off, the context menu entry is much nicer than the links in the mail body, IMO.

Thanks for the patch :)

Please close the review request.

P.S.: One thing I had considered is that the context menu entry should maybe be \
hidden instead of disabled for non-mailing list mails, to not overwhelm normal users \
who don't use mailing lists. Just an idea, and it actually does not belong to this \
review request here, this got already long enough.

- Thomas


On 2009-10-24 03:13:04, Daniel Black wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1768/
> -----------------------------------------------------------
> 
> (Updated 2009-10-24 03:13:04)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This patch displays the List{-ID,post,subscriber,unsubscribe,archive,help,owner} \
> RFC2369, List-ID is RFC2919 and Archived-At (RFC5064) URLs of email header fields \
> on header context of kmail preview pane. 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdepim/kmail/kmmainwidget.h 1039626 
> /trunk/KDE/kdepim/kmail/kmmainwidget.cpp 1039626 
> /trunk/KDE/kdepim/kmail/mailinglist-magic.h 1039626 
> /trunk/KDE/kdepim/kmail/mailinglist-magic.cpp 1039626 
> /trunk/KDE/kdepim/kmail/messageactions.h 1039626 
> /trunk/KDE/kdepim/kmail/messageactions.cpp 1039626 
> 
> Diff: http://reviewboard.kde.org/r/1768/diff
> 
> 
> Testing
> -------
> 
> tested on kmail-1.12.2 (kde-4.3.2)
> - emails from about 15 lists examined
> 
> 
> Screenshots
> -----------
> 
> displaying maillist info
> http://reviewboard.kde.org/r/1768/s/235/
> disabled on normal mail
> http://reviewboard.kde.org/r/1768/s/236/
> 
> 
> Thanks,
> 
> Daniel
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]