[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: adds kmail support for RFC2369,
From:       "Daniel Black" <daniel.subs () internode ! on ! net>
Date:       2009-10-24 3:13:04
Message-ID: 20091024031304.19237.45797 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1768/
-----------------------------------------------------------

(Updated 2009-10-24 03:13:04.306927)


Review request for KDE PIM.


Changes
-------

ok ref whitespace removal. It was where I copied some bad style from however I'll put \
it as a separate request for proper annotation if desired.

Fixed a small regression that normal emails would have the submenu enabled with an \
empty header. (menu->addTitle() means menu()->isEmpty() is always false) Fixed logic \
so that only when useful stuff populates the submenu is it actually enabled. \
(messageaction.cpp:244)

Thanks again for all the help and support.


Summary
-------

This patch displays the List{-ID,post,subscriber,unsubscribe,archive,help,owner} \
RFC2369, List-ID is RFC2919 and Archived-At (RFC5064) URLs of email header fields on \
header context of kmail preview pane.


Diffs (updated)
-----

  /trunk/KDE/kdepim/kmail/kmmainwidget.h 1039626 
  /trunk/KDE/kdepim/kmail/kmmainwidget.cpp 1039626 
  /trunk/KDE/kdepim/kmail/mailinglist-magic.h 1039626 
  /trunk/KDE/kdepim/kmail/mailinglist-magic.cpp 1039626 
  /trunk/KDE/kdepim/kmail/messageactions.h 1039626 
  /trunk/KDE/kdepim/kmail/messageactions.cpp 1039626 

Diff: http://reviewboard.kde.org/r/1768/diff


Testing (updated)
-------

tested on kmail-1.12.2 (kde-4.3.2)
- emails from about 15 lists examined


Screenshots (updated)
-----------

displaying maillist info
  http://reviewboard.kde.org/r/1768/s/235/
disabled on normal mail
  http://reviewboard.kde.org/r/1768/s/236/


Thanks,

Daniel

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]