[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] [PATCH] Nice headers for akregator
From:       Ingo =?iso-8859-1?q?Kl=F6cker?= <kloecker () kde ! org>
Date:       2008-08-17 22:14:26
Message-ID: 200808180014.30639 () thufir ! ingo-kloecker ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Sunday 17 August 2008, Allen Winter wrote:
> On Saturday 16 August 2008 16:24:34 Kolja wrote:
> > Hello!
> >
> > I'm new to kde development and this is my first
> > post to this mailing list.
> >
> > The attached patch changes the appearance of the
> > headers in akregator. For a preview take a look at:
> >
> > http://datenschreck.net/kde/akregator_freshedHeaders_beforeAfter.jp
> >g
> > http://datenschreck.net/kde/akregator_freshedHeaders_beforeAfter_co
> >mbinedView.jpg
> >
> > What's wrong with the old ones?
> >     - they look old
> >     - they do _not_ fit into the fresh oxygen
> >       environment
> >
> > What about the new ones?
> >     + they look more modern
> >     + they fit better into the environment
> >     + the title of an article is blue
> >       (QPalette::Link), so more users would
> >       recognice this as a link. With this the user
> >       can go to the complete article by "Complete
> >       Story" in the end and also by clicking the
> >       title.
> >     + if you select a feed in the tree view, the
> >       presented title (in the article viewer
> >       part/header) is now clickable (home page)
> >     + Colors (grey) from the color palette were used
> >       (http://wiki.kde.org/tiki-index.php?page=Colors)
> >     - they need more space
> >
> > The attached patch applies to the directory
> > akregator/src, but only articleformatter.cpp is
> > affected. It's meant for trunk.
> >
> > Comments and suggestions?! :)
>
> The new look seems beautiful to me.  I haven't looked at the code
> changes though. If we do this, we will need to also apply this new
> style to KMail and KNode headers.

Instead of adding/replacing the hard-coded styles they should be made 
themeable via CSS and/or HTML templates. I suggest to have a look at 
Kopete where the chat window style is completely themeable. Maybe some 
of the code can be shared.


Regards,
Ingo

["signature.asc" (application/pgp-signature)]

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

[prev in list] [next in list] [prev in thread] [next in thread]