[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] [patch] KMail: fox for text codecs + questions on
From:       Ingo =?utf-8?q?Kl=C3=B6cker?= <kloecker () kde ! org>
Date:       2008-03-14 22:39:59
Message-ID: 200803142340.00061 () erwin ! ingo-kloecker ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Friday 14 March 2008, Thomas McGuire wrote:
> Hi,
>
> On Friday 14 March 2008, Jarosław Staniek wrote:
> > For review.
> >
> > 1. For creating emails use codec returned by
> > KGlobal::locale()->encoding(), what on non-windows is equal to
> > QTextCodec::codecForLocale() (see KLocalePrivate::initEncoding()).
> > On windows QTextCodec::codecForLocale() returns "System", so we're
> > using GetLocaleInfo() to get the actual CP system's charset.
> >
> > 2. A fix for japanese codec on Windows and Mac (just switches from
> > shift-jis to jis7 in addition to the previous behaviour so would
> > not break things), see the comment added in the code.
>
> Disclaimer: I don't know much about encoding (I've only read the MIME
> RFCs now).
> I guess the patch is OK. The only problem I see is that
> networkCodec() is also used to decode MIME messages without a
> specified charset. However, according to the RFC, we should use
> us-ascii for that. But this has always been the case in KMail code,
> so I think it is no problem. I'm just wondering about the
> consequences of a changed networkCodec() here.

If we used us-ascii then a lot of mail send by users of broken products 
(mostly from a certain company) and loads of automatically generated 
messages could not be decoded correctly. Therefore we are using the 
local encoding instead of us-ascii.


Regards,
Ingo

["signature.asc" (application/pgp-signature)]

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

[prev in list] [next in list] [prev in thread] [next in thread]