--===============1810711105==
Content-type: multipart/signed; boundary=nextPart2382832.XZMA3WW3uM;
 protocol="application/pgp-signature"; micalg=pgp-sha1
Content-transfer-encoding: 7bit

--nextPart2382832.XZMA3WW3uM
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Friday 14 March 2008, Thomas McGuire wrote:
> Hi,
>
> On Friday 14 March 2008, Jaros=C5=82aw Staniek wrote:
> > For review.
> >
> > 1. For creating emails use codec returned by
> > KGlobal::locale()->encoding(), what on non-windows is equal to
> > QTextCodec::codecForLocale() (see KLocalePrivate::initEncoding()).
> > On windows QTextCodec::codecForLocale() returns "System", so we're
> > using GetLocaleInfo() to get the actual CP system's charset.
> >
> > 2. A fix for japanese codec on Windows and Mac (just switches from
> > shift-jis to jis7 in addition to the previous behaviour so would
> > not break things), see the comment added in the code.
>
> Disclaimer: I don't know much about encoding (I've only read the MIME
> RFCs now).
> I guess the patch is OK. The only problem I see is that
> networkCodec() is also used to decode MIME messages without a
> specified charset. However, according to the RFC, we should use
> us-ascii for that. But this has always been the case in KMail code,
> so I think it is no problem. I'm just wondering about the
> consequences of a changed networkCodec() here.

If we used us-ascii then a lot of mail send by users of broken products=20
(mostly from a certain company) and loads of automatically generated=20
messages could not be decoded correctly. Therefore we are using the=20
local encoding instead of us-ascii.


Regards,
Ingo

--nextPart2382832.XZMA3WW3uM
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.4-svn0 (GNU/Linux)

iD8DBQBH2v7AGnR+RTDgudgRAqLxAKCQ1X0Kgu68RDsG/klpIYE7Bq1x4QCdEdm4
HR57iquOaur5rB1r/9TV1ho=
=qykW
-----END PGP SIGNATURE-----

--nextPart2382832.XZMA3WW3uM--

--===============1810711105==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
--===============1810711105==--