[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] KDE/kdepimlibs/kcal
From:       David Jarvie <lists () astrojar ! org ! uk>
Date:       2006-09-11 22:17:41
Message-ID: 200609112317.41327.lists () astrojar ! org ! uk
[Download RAW message or body]

On Monday 11 September 2006 22:58, David Jarvie wrote:
> On Monday 11 September 2006 19:37, Reinhold Kainhofer wrote:
> > Hi David,
> >
> > Am Montag, 11. September 2006 18:41 schrieb David Jarvie:
> > >  M  +67 -67  
> > >  tests/data/RecurrenceRule/ConnectDaily/ConnectDaily1.ics.next.ref   M
> > >  +67 -68  
> > >  tests/data/RecurrenceRule/ConnectDaily/ConnectDaily1.ics.prev.ref M +1
> > > -0
> > >  tests/data/RecurrenceRule/ConnectDaily/ConnectDaily5.ics.prev.ref M
> > >  +27 -27
> > >  tests/data/RecurrenceRule/KOrganizer_3.4/KOrganizer_Test01.ics.next.re
> > >f M
> >
> > Why should a change of the internals change the reference data? These
> > files should have already contained the correct resulting date/times so
> > far (they were correct, just the output of libkcal isn't always).
> >
> > Or do I miss something here?
>
> The output now includes the time zone name where appropriate. This is
> necessary to test that things work properly. Bear in mind that unlike when
> QDateTime is used, date/time values are not just a date and a time, but
> also include the time specification (i.e. time zone etc.). So if the output
> doesn't include this, it isn't possible to check whether the test has
> worked correctly.

This raises an important issue. People need to start thinking about date/time 
values in a different way. To use just a date and a time without a time 
specification (KDateTime::Spec, which will typically represent a time zone) 
should always be considered an incomplete time representation unless there is 
a good reason to disregard the time spec. A QDateTime will normally be just 
as useless by itself as a QTime is, to represent when something happened or 
is scheduled for.

-- 
David Jarvie.
KAlarm author and maintainer.
http://www.astrojar.org.uk/linux/kalarm.html
_______________________________________________
kde-pim mailing list
kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/

[prev in list] [next in list] [prev in thread] [next in thread]