[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] [patch] Re:  Are we ready for 3.5?
From:       Allen Winter <winter () kde ! org>
Date:       2005-10-26 15:36:22
Message-ID: 200510261136.23832.winter () kde ! org
[Download RAW message or body]

On Wednesday 26 October 2005 08:08, Martin Koller wrote:
> On Friday 21 October 2005 22:40, Adriaan de Groot wrote:
> > On Friday 21 October 2005 17:28, Allen Winter wrote:
> > >  1. Kmail folder properties (esp. the Act on new/unread.. and Keep
> > > replies) get set/reset strangely by themselves.
> >
> > Get this every time KMail is kill -TERM'ed, yup; most folders lose their
> > 'act on new' setting. And kill -TERM happens often, because kmail hangs on
> > me regularly and I haven't been able to track down why.
> 
> I think I have a fix for this (attached).
> 
> A little description of what I found:
> 
> Whenever the folder-properties dialog is closed, writeConfig() is called, 
> which results in kmailrc only holding (for this folder) the setting
> isOpen = true
> 
> The rest of the setting are only stored to disk, when you change to another 
> folder.
> 
> When now you kill kmail before the rest is written, then obviously some 
> defaults are used the next time ... (which means, about 40 (!) settings are 
> lost)
> 
> isOpen = true is created from  KMFolderTree::writeIsListViewItemOpen(..)
> 
> I don't know how this whole KConfig stuff is supposed to work, but what I did 
> is, I added here a call to  folder->storage()->writeConfig();
> which is also done in the  FolderDiaGeneralTab::save() method.
> 
> I don't know why the rest of the settings are not written when isOpen is 
> written, but at least the patch solves the problem ...
> 
> OK to commit ?
> 
I applied your patch locally in my sandbox and it seems to work for me.
I changed a couple folder properties, then ran kill -TERM `pidof kontact`
and when I restarted kontact the changed properties where still there.

-- 
Let's Keep the Political Talk Out of KDE PLEASE
_______________________________________________
kde-pim mailing list
kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]