[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    [Kde-pim] [patch] Re:  Are we ready for 3.5?
From:       Martin Koller <m.koller () surfeu ! at>
Date:       2005-10-26 12:08:19
Message-ID: 200510261408.24019.m.koller () surfeu ! at
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/mixed)]


On Friday 21 October 2005 22:40, Adriaan de Groot wrote:
> On Friday 21 October 2005 17:28, Allen Winter wrote:
> >  1. Kmail folder properties (esp. the Act on new/unread.. and Keep
> > replies) get set/reset strangely by themselves.
>
> Get this every time KMail is kill -TERM'ed, yup; most folders lose their
> 'act on new' setting. And kill -TERM happens often, because kmail hangs on
> me regularly and I haven't been able to track down why.

I think I have a fix for this (attached).

A little description of what I found:

Whenever the folder-properties dialog is closed, writeConfig() is called, 
which results in kmailrc only holding (for this folder) the setting
isOpen = true

The rest of the setting are only stored to disk, when you change to another 
folder.

When now you kill kmail before the rest is written, then obviously some 
defaults are used the next time ... (which means, about 40 (!) settings are 
lost)

isOpen = true is created from  KMFolderTree::writeIsListViewItemOpen(..)

I don't know how this whole KConfig stuff is supposed to work, but what I did 
is, I added here a call to  folder->storage()->writeConfig();
which is also done in the  FolderDiaGeneralTab::save() method.

I don't know why the rest of the settings are not written when isOpen is 
written, but at least the patch solves the problem ...

OK to commit ?

-- 
Best regards/Schöne Grüße

Martin    ()  ascii ribbon campaign - against html mail 
          /\                        - against microsoft attachments

Computers and Internet gave you freedom.
TCPA would TAKE your FREEDOM!  http://www.againsttcpa.com

["foldertree.patch" (text/x-diff)]

Index: kmfoldertree.cpp
===================================================================
--- kmfoldertree.cpp	(revision 474210)
+++ kmfoldertree.cpp	(working copy)
@@ -1230,6 +1230,8 @@
   }
   KConfigGroupSaver saver(config, name);
   config->writeEntry("isOpen", fti->isOpen() );
+  if ( folder )
+    folder->storage()->writeConfig();
 }
 
 

[Attachment #8 (application/pgp-signature)]

_______________________________________________
kde-pim mailing list
kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/

[prev in list] [next in list] [prev in thread] [next in thread]