[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] [PATCH] Better context menus in KOrganizer
From:       Reinhold Kainhofer <reinhold () kainhofer ! com>
Date:       2005-07-09 21:27:52
Message-ID: 200507092327.59270.reinhold () kainhofer ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Am Freitag, 8. Juli 2005 10:45 schrieb Chris Howells:
> This patch adds Cut and Copy to the right click menu when clicking on an
> incidence in KOrganizer and adds Paste to the right click menu when
> clicking on an empty space.

Thanks!

> Is this OK to commit? 

Apart from the issues mentioned below, I'm fine with you committing it.

> Maybe also to 3.4 branch (it makes it _much_ more 
> obvious how to move entries around and consequently how to move them
> between calendars).

Are the i18n strings new? Or are they already in use somewhere else in 
korganizer? If they are new, backporting is out of question (unless you find 
strings that you can re-use).

> Index: calendarview.h
> ===================================================================
> --- calendarview.h      (revision 423901)
> +++ calendarview.h      (working copy)
> @@ -281,6 +281,10 @@
>      bool editIncidence( Incidence * );
>      /** Delete the supplied incidence. It calls the correct deleteXXX
> method*/ void deleteIncidence( Incidence * );
> +    /** Cut the supplied incidence. It calls the correct deleteXXX
> method*/ +    void cutIncidence( Incidence * );
> +    /** Copy the supplied incidence. It calls the correct deleteXXX
> method*/ 
> +    void copyIncidence( Incidence * ); 

These comments are definitely wrong (just copied and pasted). The actual 
implementation does not call any deleteXXX, but the correct edit_* method...

> Index: korganizerui.rc
> ===================================================================
> --- korganizerui.rc     (revision 423901)
> +++ korganizerui.rc     (working copy)
> @@ -1,5 +1,5 @@
>  <!DOCTYPE kpartgui>
> -<kpartgui name="korganizer" version="34">
> +<kpartgui name="korganizer" version="35">
>     <MenuBar>
>      <Menu name="file"><text>&amp;File</text>
> @@ -137,6 +137,8 @@
>    </ToolBar>
>     <Menu name="rmb_selection_popup">
> +    <Action name="edit_paste"/>
> +    <Separator/>
>      <Action name="new_event"/>
>      <Action name="new_todo"/>
>      <Merge/>

The paste methods should be at the end of the menu...
Usually you don't do so much copying of events, as you can simply move the 
events in the agenda view...

The "New XXX..." items are much more important IMO.

> Index: korganizer_part.rc
> ===================================================================
> --- korganizer_part.rc  (revision 423901)
> +++ korganizer_part.rc  (working copy)
> @@ -1,5 +1,5 @@
>  <!DOCTYPE kpartgui>
> -<kpartgui name="korganizer" version="34">
> +<kpartgui name="korganizer" version="35">
>     <MenuBar>
>      <Menu name="file"><text>&amp;File</text>
> @@ -161,6 +161,8 @@
>    </ToolBar>
>     <Menu name="rmb_selection_popup">
> +    <Action name="edit_paste"/>
> +    <Separator/>
>      <Action name="new_event"/>
>      <Action name="new_todo"/>
>      <Merge/>

Same here.

> Index: koeventpopupmenu.cpp
> ===================================================================
> --- koeventpopupmenu.cpp        (revision 423901)
> +++ koeventpopupmenu.cpp        (working copy)
> @@ -43,11 +43,15 @@
>     insertItem (i18n("&Show"),this,SLOT(popupShow()));
>    mEditOnlyItems.append(insertItem
> (i18n("&Edit..."),this,SLOT(popupEdit()))); 
> +  
> mEditOnlyItems.append(insertItem
> (KOGlobals::self()->smallIcon("editcut"),i18n("&Cut"), 

Can you please add a separator after the edit and before the copy/paste/delete 
entries to visually separe them.

Cheers,
Reinhold

-- 
------------------------------------------------------------------
Reinhold Kainhofer, Vienna, Austria
email: reinhold@kainhofer.com, http://reinhold.kainhofer.com/
 * Financial and Actuarial Mathematics, TU Wien, http://www.fam.tuwien.ac.at
 * K Desktop Environment, http://www.kde.org/, KOrganizer / KPilot maintainer

[Attachment #5 (application/pgp-signature)]

_______________________________________________
kde-pim mailing list
kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/

[prev in list] [next in list] [prev in thread] [next in thread]