[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: Fwd: Re: [Kde-pim] Bug in kitchensync's idhelper.cpp
From:       Volker Christian <voc () users ! sourceforge ! net>
Date:       2005-03-13 9:21:26
Message-ID: 200503131021.27859.voc () users ! sourceforge ! net
[Download RAW message or body]

Hi
On Friday 11 March 2005 19:28, Tobias Koenig wrote:
> On Fri, Mar 11, 2005 at 11:09:13PM +0100, Michael W. Holdeman wrote:
> > Tobias,
>
> Hi,
>
> > Though, my bug-fix itself introduces a bug :-)
> > The first fix, namely
> >
> > > >  //        kdDebug(5201) << "Already inserted" << endl;
> > > > -        Kontainer::ValueList kontainer = it.data();
> > > > +        Kontainer::ValueList &kontainer = it.data();
> > > >          Kontainer kont( konnectorId,  kdeId );
> >
> > must not be applied - it is wrong! But the other fix is correct.
>
> Why shouldn't that be ok? It saves at least one copy ctor call.
Actually, because it didn't work - at least during some of my tests! But this 
could have had other reasons too - i will check it again and let you know!

regards
voc
 
>
> Ciao,
> Tobias
_______________________________________________
kde-pim mailing list
kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]