[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] [PATCH] Kontact statusbar squeezing
From:       Volker Krause <volker.krause () rwth-aachen ! de>
Date:       2005-01-23 20:28:09
Message-ID: 200501232128.14232.volker.krause () rwth-aachen ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Sunday 23 January 2005 18:48, Ingo Klöcker wrote:
> On Sunday 23 January 2005 18:00, Volker Krause wrote:
> > On Sunday 23 January 2005 17:20, Ingo Klöcker wrote:
> > > Now a general problem:
> > > KStatusBarLabel does the following in it's c'tor:
> > > 00042   setLineWidth  (0);
> > > 00043   setFrameStyle (QFrame::NoFrame);
> > > 00044
> > > 00045   setAlignment( AlignHCenter | AlignVCenter | SingleLine );
> > >
> > > Obviously this influences the look of status bar labels and should
> > > be done for all statusbar labels (-> consistent look of all KDE
> > > applications). Therefore IMO using a non-statusbar-related label
> > > class for a status bar label is wrong. IMO the correct solution is
> > > to add squeezing to KStatusBarLabel.
> >
> > Quoting from KStatusBarLabel:
> >   setLineWidth  (0);
> >   setFrameStyle (QFrame::NoFrame);
> >
> >   setAlignment( AlignHCenter | AlignVCenter | SingleLine );
> >
> > So, I think it should be the same as before (and at least I haven't
> > seen any difference).
>
> Huh? My point is that you don't use KStatusBarLabel anymore. Instead you
> use KRSqueezedLabel which doesn't contain this code. Whether this code
> is actually necessary I don' t know. Maybe it's necessary with certain
> widget styles.

I should have read more carefully, I thought the code you quoted was from the 
status bar label. But since we use KRSqueezedTextLabel only in the status 
bar, adding these calls should be ok, then we're on the safe side. I'll have 
a look at this as soon as I have time.

regards
Volker

[Attachment #5 (application/pgp-signature)]

_______________________________________________
kde-pim mailing list
kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/

[prev in list] [next in list] [prev in thread] [next in thread]