[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] [PATCH2] libkcal::events(sorted)
From:       David Jarvie <lists () astrojar ! org ! uk>
Date:       2004-09-09 18:15:21
Message-ID: 200409091915.22282.lists () astrojar ! org ! uk
[Download RAW message or body]

On Tuesday 07 Sep 2004 16:02, Allen Winter wrote:
> On Tuesday 07 September 2004 10:42 am, Reinhold Kainhofer wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > On Tuesday,  07. September 2004 15:56, Allen Winter wrote:
> > > On Tuesday 07 September 2004 09:14 am, David Jarvie wrote:
> > > > virtual Event::List events( EventSortOrder = Unsorted );
> > > >
> > > > This would replace the existing events() method rather than be
> > > > additional to it.
> > >
> > > Yeah, that makes a lot of sense.  Too much sense... there must be
> > > something wrong with it :> Reinhold?
> >
> > Wasn't this what I suggested (using a default argument, so calls to
> > events() would return exactly the same result as before, but there's no
> > duplication of code/methods)?
>
> Yes you did..
> See attached.  Is this better?

Why not call the new rawEventsSorted(EventSortOrder) method by the existing 
method name of rawEvents(EventSortOrder) ? The parameter makes it clear that 
it's returning a sorted list (or not, if Unsorted is chosen). The Sorted bit 
of the name if really redundant.

--
David Jarvie.
_______________________________________________
kde-pim mailing list
kde-pim@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]