[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    [Kde-pim] Re: small consmetic fixes for RTL languages
From:       Diego Iastrubni <elcuco () kdemail ! net>
Date:       2004-08-24 17:43:56
Message-ID: 200408241943.56749.elcuco () kdemail ! net
[Download RAW message or body]

On Tuesday 07 Elul 5764 19:43, Diego Iastrubni wrote:
> Hi,
>
> I would like to commit this patch for kmail. What I am trying to do is
> allign the date to the right.  At the moment, all of the information in the
> fancy theme is aligned to the  left (which looks ok, dont worry).
>
> The problem is that I am removing a lot of definitions for you guys, and I
> will would like to align the "from:" and "to:" texts to the left.
>
> Is there a way for me to get the exact HTML which khtml is displaying, so I
> can hack it "offline"?
>
> --
> diego
oops :)

["kmail-rtl.diff" (text/x-diff)]

Index: csshelper.cpp
===================================================================
RCS file: /home/kde/kdepim/kmail/csshelper.cpp,v
retrieving revision 1.12
diff -u -r1.12 csshelper.cpp
--- csshelper.cpp	20 May 2004 13:36:01 -0000	1.12
+++ csshelper.cpp	24 Aug 2004 14:00:31 -0000
@@ -672,21 +672,21 @@
 
       "div.fancy.header table {\n"
       "  padding: 2px ! important;\n" // ### khtml bug: this is ignored
-      "  text-align: left ! important\n"
+//      "  text-align: left ! important\n"
       "}\n\n"
 
       "div.fancy.header table th {\n"
       "  padding: 0px ! important;\n"
       "  white-space: nowrap ! important;\n"
       "  border-spacing: 0px ! important;\n"
-      "  text-align: left ! important;\n"
+//      "  text-align: left ! important;\n"
       "  vertical-align: top ! important;\n"
       "}\n\n"
 
       "div.fancy.header table td {\n"
       "  padding: 0px ! important;\n"
       "  border-spacing: 0px ! important;\n"
-      "  text-align: left ! important;\n"
+//      "  text-align: left ! important;\n"
       "  vertical-align: top ! important;\n"
       "  width: 100% ! important;\n"
       "}\n\n"
Index: headerstyle.cpp
===================================================================
RCS file: /home/kde/kdepim/kmail/headerstyle.cpp,v
retrieving revision 1.18
diff -u -r1.18 headerstyle.cpp
--- headerstyle.cpp	5 Jun 2004 09:15:55 -0000	1.18
+++ headerstyle.cpp	24 Aug 2004 14:00:31 -0000
@@ -472,7 +472,7 @@
     // QString::arg is not possible
     if ( strategy->showHeader( "from" ) )
       headerStr += QString("<tr><th>%1</th>\n"
-                           "<td>")
+                           "<td  dir=\"ltr\">")
                            .arg(i18n("From: "))
                  + KMMessage::emailAddrAsAnchor(message->from(),FALSE)
                  + ( !vCardName.isEmpty() ? "&nbsp;&nbsp;<a href=\"" + vCardName + \
"\">" @@ -490,14 +490,14 @@
     // to line
     if ( strategy->showHeader( "to" ) )
       headerStr.append(QString("<tr><th>%1</th>\n"
-                   "<td>%2</td></tr>\n")
+                   "<td dir=\"ltr\">%2</td></tr>\n")
                             .arg(i18n("To: "))
                             \
.arg(KMMessage::emailAddrAsAnchor(message->to(),FALSE)));  
     // cc line, if any
     if ( strategy->showHeader( "cc" ) && !message->cc().isEmpty())
       headerStr.append(QString("<tr><th>%1</th>\n"
-                   "<td>%2</td></tr>\n")
+                   "<td dir=\"ltr\">%2</td></tr>\n")
                               .arg(i18n("CC: "))
                               \
.arg(KMMessage::emailAddrAsAnchor(message->cc(),FALSE)));  
@@ -507,12 +507,14 @@
                    "<td>%2</td></tr>\n")
                               .arg(i18n("BCC: "))
                               \
                .arg(KMMessage::emailAddrAsAnchor(message->bcc(),FALSE)));
-
+										
     if ( strategy->showHeader( "date" ) )
-      headerStr.append(QString("<tr><th>%1</th>\n"
-                   "<td dir=\"%2\">%3</td></tr>\n")
+      headerStr.append(QString("<tr class=\"date\">"
+												"<th dir=\"rtl\">%1</th>\n"
+                   						"<td dir=\"rtl\">%2</td>"
+										  "</tr>\n"
+										)
                             .arg(i18n("Date: "))
-                    .arg( directionOf( message->dateStr() ) )
                             .arg(strToHtml(dateString)));
 
     // FIXME: Show status in synthetic header style field.  Decide whether this or \
current in brackets style is best and remove one.



_______________________________________________
kde-pim mailing list
kde-pim@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/

[prev in list] [next in list] [prev in thread] [next in thread]