[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Kolab bugfix: Allow completion of names even if
From:       Karl-Heinz Zimmer <khz () kde ! org>
Date:       2004-08-12 9:25:49
Message-ID: 200408121125.54687 () postmaster ! bugcops ! org
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Donnerstag, 12. August 2004 00:15 schrieb Ingo Klöcker:
> On Wednesday 11 August 2004 23:31, Karl-Heinz Zimmer wrote:
> > Hi all,
> >
> > the following patch adds some functionallity we need to fix a
> > kolab bug (issue 31).
> >
> > So far AddressLineEdit could not show the respective completion
> > proposal if the user typed the addressee's last name but in the
> > database(s) only the normal first name/last name combination was
> > stored.
> >
> > So no completion is offered if you type "Brown" into the To line in
> > KMail's composer if complete name expected by KMail is "John Brown".
> >
> > The patch tries to detect the last name and adds a respective entry
> > to the completion list.
>
> This isn't a good solution because it duplicates all entries in the
> completion list.

Yes, it duplicates all entries having at least two names: should be
most of the entries.

> Moreover, if I enter "jb" then "John Brown <jbrown@something>" won't
> be shown as possible completion.

True, since this is not in the scope of this patch.  We were looking
for the more common problem that you remember the family name of your
partner but not remember the christian name.

> Instead of adding duplicates to the completion list the code which
> looks for valid completions should be changed to not only find
> addresses that start with the already entered characters, but to
> find addresses which contain a word which starts with the characters.
> Then we would complete by first name, by last name, by email address
> and by the domain part of email addresses.

Ingo, I agree that this would be better.

Do you think you still could agree to adding the patch (for now) since
it solves the most common aspect of the problem?

Our idea was that KCompletion is highly efficiently when it comes to
find the matching entries: even if there are many entries in it, so
duplicating most entries is less expensive than using another comparison
mechanism to circumvent KCompletion's method.

Of course you are right that further enhancing KCompletion would be the
best way, but this seems not possible currently.

Cheers

Karl-Heinz
- -- 
Karl-Heinz         <mailto:khz@indeview.org>        <mailto:khz@kde.org>
  Zimmer                I n d e V i e w                    K D E
  Föhren       Presentations Beyond Limitations     Conquer your Desktop
www.fiehr.de            www.indeview.org                www.kde.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQFBGzehCcaVnbvggDcRAjyfAJ92JIZLKVrAWY5zYBChRMecT3nzCgCfakTo
MnjaztPAKP2W9eTrsonULNE=
=nmEJ
-----END PGP SIGNATURE-----

_______________________________________________
kde-pim mailing list
kde-pim@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/

[prev in list] [next in list] [prev in thread] [next in thread]