[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    [Kde-pim] Giving ComponentsDialog a default description
From:       Adriaan de Groot <adridg () cs ! kun ! nl>
Date:       2004-07-23 12:11:21
Message-ID: Pine.GSO.4.44.0407231357530.13551-200000 () odin ! cs ! kun ! nl
[Download RAW message or body]

(In Kontact, but probably elsewhere as well)  If you choose
"Settings->Select Components", the dialog comes up with none of the
components selected, and a weird layout - there's the tree ist to the
left, and to the right where it is going to display the plugin icon and
description, the area is _blank_ (until you select a component). It would
be better to have _something_ there, since it looks like a layout error
otherwise.

The attached patch makes it come up with the "Configure" icon and a
"Select Components" comment, so that there is _something_ visible in the
component selection area. This does not introduce new strings.


I would like to add the description string, stating what the purpose of
the dialog is, but I guess that's impossible (hence that line is commented
out in the patch). I also see that the description label isn't actually
set anywhere - it's commented out in executed(). Is there a purpose to
that? It seems to me that printing the descriptions would be a useful
thing to do.


Finally, would it make sense to put the name of the selected component
next to its icon, above the separator bar? Many KCMs sort-of work like
that, with some sort of title above the separator.

-- 
 Adriaan de Groot    adridg@cs.kun.nl     Kamer A6020     024-3652272
GPG Key Fingerprint 934E 31AA 80A7 723F 54F9  50ED 76AC EE01 FEA2 A3FE
               http://www.cs.kun.nl/~adridg/research/

["components.diff" (TEXT/PLAIN)]

Index: ./kutils/ksettings/componentsdialog.cpp
===================================================================
RCS file: /home/kde/kdelibs/kutils/ksettings/componentsdialog.cpp,v
retrieving revision 1.10
diff -u -3 -p -r1.10 componentsdialog.cpp
--- ./kutils/ksettings/componentsdialog.cpp	5 Jul 2004 20:41:00 -0000	1.10
+++ ./kutils/ksettings/componentsdialog.cpp	23 Jul 2004 10:03:29 -0000
@@ -57,11 +57,14 @@ ComponentsDialog::ComponentsDialog( QWid
     d->infowidget->setMinimumSize( 200, 200 );
     ( new QVBoxLayout( d->infowidget, 0, KDialog::spacingHint() ) )->setAutoAdd( true );
     d->iconwidget = new QLabel( d->infowidget );
+    d->iconwidget->setPixmap( SmallIcon( "configure", KIcon::SizeLarge ) );
     ( void )new KSeparator( d->infowidget );
     d->commentwidget = new QLabel( d->infowidget );
     d->commentwidget->setAlignment( Qt::WordBreak );
+    d->commentwidget->setText( i18n("Select Components") );
     d->descriptionwidget = new QLabel( d->infowidget );
     d->descriptionwidget->setAlignment( Qt::WordBreak );
+    // d->descriptionwidget->setText( i18n("Select plugins to activate by marking them in the list.") );
 
     d->listview->addColumn( QString::null );
     d->listview->header()->hide();


_______________________________________________
kde-pim mailing list
kde-pim@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/

[prev in list] [next in list] [prev in thread] [next in thread]