This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. ---559023410-851401618-1090584681=:13551 Content-Type: TEXT/PLAIN; charset=US-ASCII (In Kontact, but probably elsewhere as well) If you choose "Settings->Select Components", the dialog comes up with none of the components selected, and a weird layout - there's the tree ist to the left, and to the right where it is going to display the plugin icon and description, the area is _blank_ (until you select a component). It would be better to have _something_ there, since it looks like a layout error otherwise. The attached patch makes it come up with the "Configure" icon and a "Select Components" comment, so that there is _something_ visible in the component selection area. This does not introduce new strings. I would like to add the description string, stating what the purpose of the dialog is, but I guess that's impossible (hence that line is commented out in the patch). I also see that the description label isn't actually set anywhere - it's commented out in executed(). Is there a purpose to that? It seems to me that printing the descriptions would be a useful thing to do. Finally, would it make sense to put the name of the selected component next to its icon, above the separator bar? Many KCMs sort-of work like that, with some sort of title above the separator. -- Adriaan de Groot adridg@cs.kun.nl Kamer A6020 024-3652272 GPG Key Fingerprint 934E 31AA 80A7 723F 54F9 50ED 76AC EE01 FEA2 A3FE http://www.cs.kun.nl/~adridg/research/ ---559023410-851401618-1090584681=:13551 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="components.diff" Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename="components.diff" SW5kZXg6IC4va3V0aWxzL2tzZXR0aW5ncy9jb21wb25lbnRzZGlhbG9nLmNw cA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZpbGU6IC9ob21lL2tk ZS9rZGVsaWJzL2t1dGlscy9rc2V0dGluZ3MvY29tcG9uZW50c2RpYWxvZy5j cHAsdg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjEwDQpkaWZmIC11IC0zIC1w IC1yMS4xMCBjb21wb25lbnRzZGlhbG9nLmNwcA0KLS0tIC4va3V0aWxzL2tz ZXR0aW5ncy9jb21wb25lbnRzZGlhbG9nLmNwcAk1IEp1bCAyMDA0IDIwOjQx OjAwIC0wMDAwCTEuMTANCisrKyAuL2t1dGlscy9rc2V0dGluZ3MvY29tcG9u ZW50c2RpYWxvZy5jcHAJMjMgSnVsIDIwMDQgMTA6MDM6MjkgLTAwMDANCkBA IC01NywxMSArNTcsMTQgQEAgQ29tcG9uZW50c0RpYWxvZzo6Q29tcG9uZW50 c0RpYWxvZyggUVdpZA0KICAgICBkLT5pbmZvd2lkZ2V0LT5zZXRNaW5pbXVt U2l6ZSggMjAwLCAyMDAgKTsNCiAgICAgKCBuZXcgUVZCb3hMYXlvdXQoIGQt PmluZm93aWRnZXQsIDAsIEtEaWFsb2c6OnNwYWNpbmdIaW50KCkgKSApLT5z ZXRBdXRvQWRkKCB0cnVlICk7DQogICAgIGQtPmljb253aWRnZXQgPSBuZXcg UUxhYmVsKCBkLT5pbmZvd2lkZ2V0ICk7DQorICAgIGQtPmljb253aWRnZXQt PnNldFBpeG1hcCggU21hbGxJY29uKCAiY29uZmlndXJlIiwgS0ljb246OlNp emVMYXJnZSApICk7DQogICAgICggdm9pZCApbmV3IEtTZXBhcmF0b3IoIGQt PmluZm93aWRnZXQgKTsNCiAgICAgZC0+Y29tbWVudHdpZGdldCA9IG5ldyBR TGFiZWwoIGQtPmluZm93aWRnZXQgKTsNCiAgICAgZC0+Y29tbWVudHdpZGdl dC0+c2V0QWxpZ25tZW50KCBRdDo6V29yZEJyZWFrICk7DQorICAgIGQtPmNv bW1lbnR3aWRnZXQtPnNldFRleHQoIGkxOG4oIlNlbGVjdCBDb21wb25lbnRz IikgKTsNCiAgICAgZC0+ZGVzY3JpcHRpb253aWRnZXQgPSBuZXcgUUxhYmVs KCBkLT5pbmZvd2lkZ2V0ICk7DQogICAgIGQtPmRlc2NyaXB0aW9ud2lkZ2V0 LT5zZXRBbGlnbm1lbnQoIFF0OjpXb3JkQnJlYWsgKTsNCisgICAgLy8gZC0+ ZGVzY3JpcHRpb253aWRnZXQtPnNldFRleHQoIGkxOG4oIlNlbGVjdCBwbHVn aW5zIHRvIGFjdGl2YXRlIGJ5IG1hcmtpbmcgdGhlbSBpbiB0aGUgbGlzdC4i KSApOw0KIA0KICAgICBkLT5saXN0dmlldy0+YWRkQ29sdW1uKCBRU3RyaW5n OjpudWxsICk7DQogICAgIGQtPmxpc3R2aWV3LT5oZWFkZXIoKS0+aGlkZSgp Ow0K ---559023410-851401618-1090584681=:13551 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kde-pim mailing list kde-pim@mail.kde.org https://mail.kde.org/mailman/listinfo/kde-pim kde-pim home page at http://pim.kde.org/ ---559023410-851401618-1090584681=:13551--