[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] [PATCH] Allowing working hour setting on half-hours and
From:       Cornelius Schumacher <schumacher () kde ! org>
Date:       2004-03-29 23:03:37
Message-ID: 200403300103.38027.schumacher () kde ! org
[Download RAW message or body]

On Tuesday 30 March 2004 00:54, Reinhold Kainhofer wrote:
>
> This patch converts the KPrefsWidTime from integer spin boxes to
> arbitrary-minute KOTimeEdits, the config fields from int to DateTime,
> and adjusts the display to use these values.

Very good idea.

> The reason I'm not committing it yet is that for this I had to move
> KOTimeEdit from the korganizer dir to the libkdepim directory.

This shouldn't be a problem, but we should probably rename it to 
KTimeEdit then.

> Any objections to commit? If not, is it okay to cvs remove the
> ktimeedit. {h,cpp} from korganizer/ and just add it to libkdepim, or
> should I contact one of the cvs admins to move the whole file so that
> we have preserve the history.

Removing and adding is ok, but you should make sure that the log message 
for both the removed and the added file clearly says which files were 
moved from which location to which other location.

-- 
Cornelius Schumacher <schumacher@kde.org>
_______________________________________________
kde-pim mailing list
kde-pim@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]