[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Re: [PATCH] Address conduit keeps addressbook locked
From:       Reinhold Kainhofer <reinhold () kainhofer ! com>
Date:       2003-09-11 10:23:26
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Donnerstag, 11. September 2003 11:50 schrieb Tobias Koenig:
> On Thu, Sep 11, 2003 at 11:02:49AM +0200, Reinhold Kainhofer wrote:
> > - From what Cornelius told me, the ticket should be deleted when saving
> > the addressbook, so that seems to be a bug in libkabc.
>
> Not a bug but a feature ;)

Then it needs to be reverted. Such behavior changes break all apps written for 
KDE 3.1. Remember the compatibility requirements for kdelibs: If you upgrade 
kdelibs, all apps need to be able to run just like before. 
Now, if you update to kdelibs 3.2, but keep kdepim 3.1, kpilot will lock the 
addressbook forever (until kpilotDaemon is killed). This is simply not 
acceptable.

I know, it's a curse for the library developers, but the application 
developers need to have a rock-stable library interface that doesn't change 
ever other week!

> I introduced this behaviour, because if the save goes wrong your save
> ticket is lost. With the current behaviour you can keep the ticket (and
> also the lock) as long as you need it.

Good idea, but I guess it has to wait for kde 4. 

And, if you make such large behavior changes, *please tell the other 
developers about it*! It's really frustrating if your app breaks for some 
unknown reason, and when you sit down and debug for hours, you find out that 
the library's  behavior changed. I already had this a year ago when libkabc 
was under heavy development, and I was about to quit developing the 
addressbook conduit, because it was so frustrating hunting bugs/behavior 
changes in the library. 

> > I didn't check it recently, but a few weeks ago, it worked fine for me.
>
> Yes, it was part of the changes in N7y

Did you talk with Cornelius about that?

Reinhold
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE/YE0eTqjEwhXvPN0RAocaAJ0VVWhYS1B8LMzLxj3GFVt+ziW7twCfZG5w
1emdPUxUlTDzOk9fJsHShNs=
=6qRv
-----END PGP SIGNATURE-----
_______________________________________________
kde-pim mailing list
kde-pim@mail.kde.org
http://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/

[prev in list] [next in list] [prev in thread] [next in thread]