[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] [PATCH] KAgenda L&F changes
From:       Cornelius Schumacher <schumacher () kde ! org>
Date:       2003-07-24 21:32:42
[Download RAW message or body]

On Thursday 24 July 2003 20:22, Tim Jansen wrote:
> On Thursday 24 July 2003 10:03, you wrote:
> > Yes, but that's only the default event color, the highlight color
> > etc. If the user assigned custom colors to categories these should
> > be preserved. These are arbitrary user-defined colors anyway, we
> > don't have any influence on that.
>
> The problem is that if the user has not defined her own colors, the
> config contains the old defaults as category colorand the user would
> never see the new colors. I now reverted my category color change.
> Instead I check whether the category color is the old default color
> and override it with the new one. Ugly, but the user keeps the colors
> if she changed them and otherwise will get the new ones...

That will make it impossible to configure the old default category color 
as custom category color. I now realize where the problem lies. Old 
KOrganizer versions wrote the default categories colors to the config 
file, even if the user didn't change them. So we have no way to 
differentiate if the user didn't change the defaults or explicitly set 
the default value. So I think the best solution would be to use a new 
group and copy the colors at the first start (maybe by kconf_update) to 
the new group if they are different from the old default color.

> > > What about changing the frame color? Changed the patch to make
> > > the frame brighter when selected.
> >
> > Ok, that's better. But it doesn't work, when the color of the event
> > is very dark. For a black event, the selection isn't visible at
> > all.
>
> No, that's not a problem. When the item is selected it makes the
> background color brighter instead of darker. So if the event is black
> the selected frame will be grey. If the event is white the frame will
> be grey when unselected and white when selected.

This doesn't work for me. If I set the default event color to black, the 
selection isn't visible.

> > Could you address the issues I mentioned above and then commit the
> > patch? We can solve remaining problems in CVS then.
>
> Committed.

Thanks.

Another idea which just came to my mind while playing with the new 
aganda view items: Wouldn't it be cool if the times would be updated 
while moving an event with the mouse. Currently the time is updated 
when the event is dropped, but if it would be updated while still 
dragging one could see at once at which time the event will end when 
being dropped.

-- 
Cornelius Schumacher <schumacher@kde.org>
_______________________________________________
kde-pim mailing list
kde-pim@mail.kde.org
http://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]