[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] [PATCH] KAgenda L&F changes
From:       Tim Jansen <ml () tjansen ! de>
Date:       2003-07-24 18:22:28
[Download RAW message or body]

On Thursday 24 July 2003 10:03, you wrote:
> Yes, but that's only the default event color, the highlight color etc. If
> the user assigned custom colors to categories these should be preserved.
> These are arbitrary user-defined colors anyway, we don't have any influence
> on that.

The problem is that if the user has not defined her own colors, the config 
contains the old defaults as category colorand the user would never see the 
new colors. I now reverted my category color change. Instead I check whether 
the category color is the old default color and override it with the new one. 
Ugly, but the user keeps the colors if she changed them and otherwise will 
get the new ones...

> > > - All-day events shouldn't never have a time header.
> > Why? They currently have a special form of headers: on the first day they
> You are talking about multi-day events, which have a certain start and end
> time. That's ok. What I meant are the events without time that appear in
> the top part of the agenda view. At the moment they all are shown with a
> time "0:00 - 0:00". That's not really helpful ;-)

Ahh, I see, fixed.

> > What about changing the frame color? Changed the patch to make the frame
> > brighter when selected.
> Ok, that's better. But it doesn't work, when the color of the event is very
> dark. For a black event, the selection isn't visible at all. 

No, that's not a problem. When the item is selected it makes the background 
color brighter instead of darker. So if the event is black the selected frame 
will be grey. If the event is white the frame will be grey when unselected 
and white when selected.

> Could you address the issues I mentioned above and then commit the patch? 
> We can solve remaining problems in CVS then.

Committed.

bye...

_______________________________________________
kde-pim mailing list
kde-pim@mail.kde.org
http://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]