[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] [PATCH] KAgenda L&F changes
From:       Cornelius Schumacher <schumacher () kde ! org>
Date:       2003-07-24 8:03:54
[Download RAW message or body]

On Wednesday 23 July 2003 22:46, Tim Jansen wrote:
> On Wednesday 23 July 2003 11:53, Cornelius Schumacher wrote:
>
> > - Why do you rename the config file group for the category colors? This
> > means that the user loses hist custom category color settings, right?
>
> That was the intention, yes :)
> The problem is that otherwise KOrganizer uses the default colors that have
> been stored in the config file before, and they usually look bad with the
> frame.

Yes, but that's only the default event color, the highlight color etc. If the 
user assigned custom colors to categories these should be preserved. These 
are arbitrary user-defined colors anyway, we don't have any influence on 
that.

> > - All-day events shouldn't never have a time header.
>
> Why? They currently have a special form of headers: on the first day they
> show the start time, and on the last day the end time. The events between
> them don't have a header. IMHO this is consistent with the rest. The header
> line is also needed for icons.

You are talking about multi-day events, which have a certain start and end 
time. That's ok. What I meant are the events without time that appear in the 
top part of the agenda view. At the moment they all are shown with a time 
"0:00 - 0:00". That's not really helpful ;-) 

> > - Wouldn't it look better to center the text on the item, at least when
> > it isn't wrapped? Especially with multiple day all-day events it looks
> > odd when the text is on the
>
> IMHO this looks better for one-line descriptions, but bad when the
> description has several lines. Having 10 lines h-centered looks really odd.
> Changed it this way.

Ok, that looks fine.

> > - When the highlight color is very similar to the color of the event
> > (e.g. because of a category color), it becomes impossible to tell, if an
> > event is selected or not. I think we need another way to indicate
> > selection of an event than only changing the color.
>
> What about changing the frame color? Changed the patch to make the frame
> brighter when selected.

Ok, that's better. But it doesn't work, when the color of the event is very 
dark. For a black event, the selection isn't visible at all. I think the 
color of the selection also has to be calculated in a way it gives sufficient 
contrast.

Thanks for all the work you have put into this patch. Could you address the 
issues I mentioned above and then commit the patch? We can solve remaining 
problems in CVS then.

-- 
Cornelius Schumacher <schumacher@kde.org>

_______________________________________________
kde-pim mailing list
kde-pim@mail.kde.org
http://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]