[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] [PATCH] KNotes (some items of the todo list...)
From:       Michael Brade <brade () kde ! org>
Date:       2003-04-26 13:14:34
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Saturday 26 April 2003 04:33, Gerold J. Wucherpfennig wrote:
> > Alright, there's a few things to be mentioned:
> >   - First of all, to make reading patches easier, please don't inlcude
> > those heaps of whitespace changes
>
> Then I could use the patch option to ignore them, no need to change
> things...
That's what I meant with include [in the patch] ;-) The option is cvs diff -b.

> >   - you changed KNote's constructor to pass a KNotesApp object. This
> > should not be done as every KNote should be independend of the
> > application using it. I want to make a KNote a plugin later. Also, I
> > can't see *why* you did it.
>
> I coded the slots in knotesapp, because there was some sample code to
> get through all notes. I think I can do it in knotes directly, but I'm not
> sure, I have to take a look into the code first...
I see, somehow I overlooked that. Easy. Just add a signal to KNote, telling 
what the user did and connect to it in KNotesApp after creating the new note. 
That's how it's done with sigNewNote(), for instance.

> > Now to the semantics:
> >
> > What's the sense of being able to select a note? Only to be able to kill
> > them?
>
> To select a group of notes and kill, show or hide them.
Hmm, show seems impossible to me, as to select a note, it has to be shown. 
Hide, well, just click on the close button instead of the select button, 
saves one click ;). Regarding kill, yes, I know about that problem and 
haven't found a good solution yet.

> First I wanted to do that with the shift key, but the X samples in kdm &
> kbd was too complicated for me, I wanted to add this later if I can figure
> it out somehow.
Oh? What do you mean? Shift-click on close? Great idea! (puh, yet another 
hidden feature...)
And it is simple to implement, qt provides this stuff already. For example, 
QMouseEvent::button() returns a ButtonState which includes the Shift-Key. 

> >  Hmm. Not perfectly happy with that. Why not delete the note directly?
> > OTOH, if we could find some more useful actions for a set of notes that
> > concept might be a good idea.
>
> Have you tried to kill 100 notes like this? Even closing all notes is a
> pain...
But isn't there no difference at all in selecting 100 notes first? With the 
Shift-thingy it should be fine, IMHO. Do you want to implement it?

> This was my only reason to code it. And if you aren't happy with
> that, I don't care. I find it useful and will keep it in my local cvs dir.
I didn't want to offend you... and yes, that's the joy of open source, 
everyone can change it to his/her own needs. Guess what my cvs looks like ;-)

> > There's a problem with hide/show all notes the way you implemented it:
> > hide all hides all notes on all desktops. Show all will then show all
> > hidden notes on the current desktop. Even more, in your case, show all
> > notes will *move all* notes to the current desktop regardless of the
> > state. This is definitely not what you want. The solution is to either
> > save the last desktop for every note and use this member only in case of
> > ShowAllNotes or, that's what I'd like to have, hideAll hides only the
> > notes on the current desktop.
>
> I don't have a problem with this and I don't want to save the
> desktop number.
Ok, fine. Gonna code it? :-)

> > Sorry for being picky, but I hope you get the ideas.
>
> Well I must admit, that I didn't care much about that,
> I was happy that I to got it to work. It was ok for me
> personally. But instead of committing it I asked you
> to give me some impressions. You know, if you have worked
> at something you don't see such little errors and it's good if
> somebody else reviews it. I didn't even know any more that I
> changed the constructor :-x
Hehe :-) That's alright. But if I'm mostly happy with it, there's no reason to 
keep it. I already had some email discussion about this hide/show all thing 
and it seems there is no perfect solution. But hiding all notes on the 
current desktop might be close.

-- 
Michael Brade;                 KDE Developer, Student of Computer Science
  |-mail: echo brade !#|tr -d "c oh"|s\e\d 's/e/\@/2;s/$/.org/;s/bra/k/2'
  °--web: http://www.kde.org/people/michaelb.html

KDE 3: The Next Generation in Desktop Experience

[Attachment #5 (application/pgp-signature)]

_______________________________________________
kde-pim mailing list
kde-pim@mail.kde.org
http://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]