[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] address formatting
From:       Tobias Koenig <tokoe () kde ! org>
Date:       2002-11-29 12:50:49
[Download RAW message or body]

On Fri, Nov 29, 2002 at 01:46:40AM +0100, Jost Schenck wrote:
> On Donnerstag, 28. November 2002 21:12, Tobias Koenig wrote:
> > The source looks good but I couldn't test it since addresseeditwidget
> > gets broken during the merge.
> 
> Ooops, sorry!
It was not you, the cvs says it was Marc... ;)

> > I did some changes in address.cpp ( exchanging QString.isNull() &&
> > QString == "" with QString.isEmpty() and some coding style stuff).
> > I would commit them tomorrow. Could you test them to make sure that I
> > don't break something?
> 
> Sure. 
> 
> By the way, I assure you I studied the hacking guidelines and I really want
> to fit my coding into your style. If you change any style stuff, please tell
> me what was the problem, so I can do it better next time :)
I only add some spaces between brackets and variables, the rest of your
code is really good concerning the coding style.

Ciao,
Tobias
-- 
In a world without walls and fences who
needs Windows and Gates???
_______________________________________________
kde-pim mailing list
kde-pim@mail.kde.org
http://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]