[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D12498: Fully remove `Application Name` from Details panel
From:       Nathaniel Graham <noreply () phabricator ! kde ! org>
Date:       2018-09-27 23:07:43
Message-ID: 8b48847d03eec235659386e0f1b88797 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

ngraham added a comment.


  > The XML file is auto-generated by the form editor in QtCreator. I don't have any \
control over it. And I don't want to mess with it by hand - too easy to break.  
  You pretty much have to, or else the diff is impossible to review, and it's easy \
for unintentional changes to sneak in. `.ui` files just aren't any fun, and this \
issue is why I suggested porting it to QML in T8569 \
<https://phabricator.kde.org/T8569>.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D12498

To: sharvey, bruns, ngraham, davidedmundson
Cc: davidedmundson, bruns, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D12498">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; \
font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: \
#f8f9fc;"><p>The XML file is auto-generated by the form editor in QtCreator. I don't \
have any control over it. And I don't want to mess with it by hand - too easy to \
break.</p></blockquote>

<p>You pretty much have to, or else the diff is impossible to review, and it&#039;s \
easy for unintentional changes to sneak in. <tt style="background: #ebebeb; \
font-size: 13px;">.ui</tt> files just aren&#039;t any fun, and this issue is why I \
suggested porting it to QML in <a href="https://phabricator.kde.org/T8569" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">T8569</a>.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R121 Policykit (Polkit) KDE \
Agent</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D12498">https://phabricator.kde.org/D12498</a></div></div><br \
/><div><strong>To: </strong>sharvey, bruns, ngraham, davidedmundson<br /><strong>Cc: \
</strong>davidedmundson, bruns, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]