[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D12498: Fully remove `Application Name` from Details panel
From:       Scott Harvey <noreply () phabricator ! kde ! org>
Date:       2018-09-27 23:03:14
Message-ID: b763d3f13c6cbe3c2a5ef607913b7a49 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

sharvey added inline comments.

INLINE COMMENTS

> bruns wrote in authdetails.ui:20
> Can you try to restore/use the same item order in the XML file as previously?
> Should make the diff significantly smaller, and easier to review.

The XML file is auto-generated by the form editor in QtCreator. I don't have any \
control over it. And I don't want to mess with it by hand - too easy to break.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D12498

To: sharvey, bruns, ngraham, davidedmundson
Cc: davidedmundson, bruns, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">sharvey added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D12498">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D12498#inline-85442">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">bruns</span> wrote in <span style="color: \
#4b4d51; font-weight: bold;">authdetails.ui:20</span></div> <div style="margin: 8px \
0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Can you try \
to restore/use the same item order in the XML file as previously?<br /> Should make \
the diff significantly smaller, and easier to review.</p></div></div> <div \
style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">The XML \
file is auto-generated by the form editor in QtCreator. I don't have any control over \
it. And I don't want to mess with it by hand - too easy to \
break.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R121 Policykit (Polkit) KDE \
Agent</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D12498">https://phabricator.kde.org/D12498</a></div></div><br \
/><div><strong>To: </strong>sharvey, bruns, ngraham, davidedmundson<br /><strong>Cc: \
</strong>davidedmundson, bruns, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]