[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D15160: [Folder View] Honor editable_desktop_icons KIOSK restriction
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2018-08-30 8:53:21
Message-ID: 1ecf7c720a31783f44f13de69938961b () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

broulik created this revision.
broulik added reviewers: Plasma, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Disallows moving desktop icons, basically force-enables the "positions locked" \
option

TEST PLAN
  - Verified that the checkbox in settings and the context menu was checked and \
                disabled
  - Verified that it didn't touch the stored config so disabling the restriction \
                would restore movable icons if it was enabled before
  - Verified that changing the setting works if restriction isnt enabled
  
  The docs also mention "renaming" and "removing" icons but this should be done by \
making Desktop folder read-only, which FolderView also doesn't handle very well. \
Dolphin, for instance, disables renaming and deleting right away whereas Folder View \
allows and then fails when doing so. Will fix that separately.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15160

AFFECTED FILES
  containments/desktop/package/contents/ui/ConfigIcons.qml
  containments/desktop/package/contents/ui/FolderViewLayer.qml
  containments/desktop/plugins/folder/viewpropertiesmenu.cpp
  containments/desktop/plugins/folder/viewpropertiesmenu.h

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">broulik created this revision.<br />broulik added reviewers: \
Plasma, davidedmundson.<br />Herald added a project: Plasma.<br />Herald added a \
subscriber: plasma-devel.<br />broulik requested review of this revision. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15160">View \
Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>Disallows moving desktop icons, basically force-enables the \
&quot;positions locked&quot; option</p></div></div><br /><div><strong>TEST \
PLAN</strong><div><ul class="remarkup-list"> <li class="remarkup-list-item">Verified \
that the checkbox in settings and the context menu was checked and disabled</li> <li \
class="remarkup-list-item">Verified that it didn&#039;t touch the stored config so \
disabling the restriction would restore movable icons if it was enabled before</li> \
<li class="remarkup-list-item">Verified that changing the setting works if \
restriction isnt enabled</li> </ul>

<p>The docs also mention &quot;renaming&quot; and &quot;removing&quot; icons but this \
should be done by making Desktop folder read-only, which FolderView also doesn&#039;t \
handle very well. Dolphin, for instance, disables renaming and deleting right away \
whereas Folder View allows and then fails when doing so. Will fix that \
separately.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 \
Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D15160">https://phabricator.kde.org/D15160</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>containments/desktop/package/contents/ui/ConfigIcons.qml<br \
/> containments/desktop/package/contents/ui/FolderViewLayer.qml<br />
containments/desktop/plugins/folder/viewpropertiesmenu.cpp<br />
containments/desktop/plugins/folder/viewpropertiesmenu.h</div></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, davidedmundson<br /><strong>Cc: \
</strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]