broulik created this revision.
broulik added reviewers: Plasma, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Disallows moving desktop icons, basically force-enables the "positions locked" option

TEST PLAN
  - Verified that the checkbox in settings and the context menu was checked and disabled
  - Verified that it didn't touch the stored config so disabling the restriction would restore movable icons if it was enabled before
  - Verified that changing the setting works if restriction isnt enabled
  
  The docs also mention "renaming" and "removing" icons but this should be done by making Desktop folder read-only, which FolderView also doesn't handle very well. Dolphin, for instance, disables renaming and deleting right away whereas Folder View allows and then fails when doing so. Will fix that separately.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15160

AFFECTED FILES
  containments/desktop/package/contents/ui/ConfigIcons.qml
  containments/desktop/package/contents/ui/FolderViewLayer.qml
  containments/desktop/plugins/folder/viewpropertiesmenu.cpp
  containments/desktop/plugins/folder/viewpropertiesmenu.h

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart