[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D14035: Unbreak SSH agent support for SSH VPN tunnels.
From:       Jan Grulich <noreply () phabricator ! kde ! org>
Date:       2018-08-01 5:30:30
Message-ID: d219063dfef3dbc93bffaec32530b86f () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

jgrulich requested changes to this revision.
jgrulich added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> secretagent.cpp:370
> +                          QLatin1String("SSH_AUTH_SOCK not present"),
> +                          request.message);
> +            } else {

You should also return true to indicate that the request is completed, otherwise it \
will still continue.

REVISION DETAIL
  https://phabricator.kde.org/D14035

To: catherinez, #plasma, jgrulich
Cc: plasma-devel, #plasma, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">jgrulich requested changes to this revision.<br />jgrulich \
added inline comments.<br />This revision now requires changes to proceed. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14035">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D14035#inline-76718">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">secretagent.cpp:370</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">                          <span \
class="n">QLatin1String</span><span class="p">(</span><span style="color: \
#766510">&quot;SSH_AUTH_SOCK not present&quot;</span><span class="p">),</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);">                          <span class="n">request</span><span \
class="p">.</span><span class="n">message</span><span class="p">);</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">          \
<span class="p">}</span> <span style="color: #aa4000">else</span> <span \
class="p">{</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You \
should also return true to indicate that the request is completed, otherwise it will \
still continue.</p></div></div></div></div></div><br /><div><strong>REVISION \
DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14035">https://phabricator.kde.org/D14035</a></div></div><br \
/><div><strong>To: </strong>catherinez, Plasma, jgrulich<br /><strong>Cc: \
</strong>plasma-devel, Plasma, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]