[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D14493: fontinst quits after KJob is done
From:       Nathaniel Graham <noreply () phabricator ! kde ! org>
Date:       2018-07-31 17:23:01
Message-ID: ac79969359eccdd4fa34b7bb23a68a4c () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

ngraham added a comment.


  Generally speaking, bugfixes go into the stable branches. If the bugfix is \
particularly large, complex, or risky, it might be worth it to commit to master only. \
For this one, I think it's okay to commit it to the `Plasma/5.12` branch too.  
  The preferred workflow here is to commit to the earliest branch and then merge; so \
that would mean committing to the `Plasma/5.12` branch, and then merging the \
`Plasma/5.12` into the `Plasma/5.13` branch, and then merging the `Plasma/5.13` \
branch into master.  
  However since you already committed it to master, that's not an option, and it will \
need to be cherry-picked to `Plasma/5.12`, and then `Plasma/5.12` merged into \
`Plasma/5.13`, with no final merge to master.  
  But I'll let one of the more experienced plasma developers have the final say in \
this matter.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14493

To: mathiastillman, #plasma, dfaure, aacid, gateau
Cc: wbauer, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D14493">View Revision</a></tr></table><br \
/><div><div><p>Generally speaking, bugfixes go into the stable branches. If the \
bugfix is particularly large, complex, or risky, it might be worth it to commit to \
master only. For this one, I think it&#039;s okay to commit it to the <tt \
style="background: #ebebeb; font-size: 13px;">Plasma/5.12</tt> branch too.</p>

<p>The preferred workflow here is to commit to the earliest branch and then merge; so \
that would mean committing to the <tt style="background: #ebebeb; font-size: \
13px;">Plasma/5.12</tt> branch, and then merging the <tt style="background: #ebebeb; \
font-size: 13px;">Plasma/5.12</tt> into the <tt style="background: #ebebeb; \
font-size: 13px;">Plasma/5.13</tt> branch, and then merging the <tt \
style="background: #ebebeb; font-size: 13px;">Plasma/5.13</tt> branch into \
master.</p>

<p>However since you already committed it to master, that&#039;s not an option, and \
it will need to be cherry-picked to <tt style="background: #ebebeb; font-size: \
13px;">Plasma/5.12</tt>, and then <tt style="background: #ebebeb; font-size: \
13px;">Plasma/5.12</tt> merged into <tt style="background: #ebebeb; font-size: \
13px;">Plasma/5.13</tt>, with no final merge to master.</p>

<p>But I&#039;ll let one of the more experienced plasma developers have the final say \
in this matter.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 \
Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14493">https://phabricator.kde.org/D14493</a></div></div><br \
/><div><strong>To: </strong>mathiastillman, Plasma, dfaure, aacid, gateau<br \
/><strong>Cc: </strong>wbauer, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]