[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D14493: fontinst quits after KJob is done
From: Mathias Tillman <noreply () phabricator ! kde ! org>
Date: 2018-07-31 9:39:46
Message-ID: b533f29d0366fac7809f7822491e31a1 () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
mathiastillman added a comment.
Okay, that makes sense. kfontinst doesn't actually display a UI at all, instead it \
just receives dbus commands from kcm - so there is no real GUI class, it just uses \
QCoreApplication. I could add a QEventLoopLocker to KFI::FontInst though, but, from \
reading the code it seems as though there's no way to actually cancel the running \
kjob (nor the running fontinst). That might be a cleaner approach than completely \
disabling the quit lock, however.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D14493
To: mathiastillman, #plasma, dfaure, aacid, gateau
Cc: wbauer, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart
[Attachment #3 (text/html)]
<table><tr><td style="">mathiastillman added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D14493">View Revision</a></tr></table><br \
/><div><div><p>Okay, that makes sense. kfontinst doesn't actually display a UI \
at all, instead it just receives dbus commands from kcm - so there is no real GUI \
class, it just uses QCoreApplication. I could add a QEventLoopLocker to KFI::FontInst \
though, but, from reading the code it seems as though there's no way to actually \
cancel the running kjob (nor the running fontinst). That might be a cleaner approach \
than completely disabling the quit lock, however.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14493">https://phabricator.kde.org/D14493</a></div></div><br \
/><div><strong>To: </strong>mathiastillman, Plasma, dfaure, aacid, gateau<br \
/><strong>Cc: </strong>wbauer, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic