[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D14493: fontinst quits after KJob is done
From:       David Faure <noreply () phabricator ! kde ! org>
Date:       2018-07-31 8:52:53
Message-ID: 453c3bd7aba337f9658d14dabd3eb4e9 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

dfaure added a comment.


  The idea of KJob reference-counting the event loop is that if you quit the \
application while a kjob is executing, then the process will wait for the job to \
finish before quitting. (Use case back then, konqueror and a HTTP download).  The \
reason why we don't just quit after the first job is that KMainWindow itself uses \
QEventLoopLocker too, increasing the refcount as long as there are visible windows.  
  If kfontinst has no way to quit while a job is happening, this patch is ok.
  But maybe it would be better to create a QEventLoopLocker in whichever GUI class \
kfontinst creates?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14493

To: mathiastillman, #plasma, dfaure, aacid, gateau
Cc: wbauer, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">dfaure added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D14493">View Revision</a></tr></table><br \
/><div><div><p>The idea of KJob reference-counting the event loop is that if you quit \
the application while a kjob is executing, then the process will wait for the job to \
finish before quitting. (Use case back then, konqueror and a HTTP download).<br /> \
The reason why we don&#039;t just quit after the first job is that KMainWindow itself \
uses QEventLoopLocker too, increasing the refcount as long as there are visible \
windows.</p>

<p>If kfontinst has no way to quit while a job is happening, this patch is ok.<br />
But maybe it would be better to create a QEventLoopLocker in whichever GUI class \
kfontinst creates?</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14493">https://phabricator.kde.org/D14493</a></div></div><br \
/><div><strong>To: </strong>mathiastillman, Plasma, dfaure, aacid, gateau<br \
/><strong>Cc: </strong>wbauer, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]