[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D14493: fontinst quits after KJob is done
From:       Mathias Tillman <noreply () phabricator ! kde ! org>
Date:       2018-07-30 17:13:01
Message-ID: 291be242f8af077d235f56c0476f1099 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

mathiastillman created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
mathiastillman requested review of this revision.

REVISION SUMMARY
  As the summary says, when installing/removing multiple fonts to system the expected \
behaviour would be for fontinst to keep running after the first font has been \
installed or removed, instead it quits which causes a bunch of issues. fontinst uses \
KJob to authorize and internally KJob uses a QEventLoopLocker which causes the main \
event loop to quit when it's done.  I'm not entirely sure why the event loop locker \
is enabled by default for KJob, but the patch I have attached works around this by \
completely disabling that functionality for fontinst. There's a timer that runs in \
the background which checks for any connected clients, so it will quit after a little \
while regardless.  See #379524 and #379324 at bugs.kde.org.

TEST PLAN
  Make sure fonts are still installed and removed properly.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14493

AFFECTED FILES
  kcms/kfontinst/dbus/Main.cpp

To: mathiastillman
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">mathiastillman created this revision.<br />Restricted \
Application added a project: Plasma.<br />Restricted Application added a subscriber: \
plasma-devel.<br />mathiastillman requested review of this revision. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14493">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>As the \
summary says, when installing/removing multiple fonts to system the expected \
behaviour would be for fontinst to keep running after the first font has been \
installed or removed, instead it quits which causes a bunch of issues. fontinst uses \
KJob to authorize and internally KJob uses a QEventLoopLocker which causes the main \
event loop to quit when it&#039;s done.<br /> I&#039;m not entirely sure why the \
event loop locker is enabled by default for KJob, but the patch I have attached works \
around this by completely disabling that functionality for fontinst. There&#039;s a \
timer that runs in the background which checks for any connected clients, so it will \
quit after a little while regardless.<br /> See #379524 and #379324 at \
bugs.kde.org.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Make sure \
fonts are still installed and removed properly.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14493">https://phabricator.kde.org/D14493</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>kcms/kfontinst/dbus/Main.cpp</div></div></div><br \
/><div><strong>To: </strong>mathiastillman<br /><strong>Cc: </strong>plasma-devel, \
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, \
apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]