[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D10040: Add serial number and EISA ID to OutputDevice interface
From:       Roman Gilg <noreply () phabricator ! kde ! org>
Date:       2018-07-30 16:12:16
Message-ID: b7ce8becc00246d7cf80deec6e14afde () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

romangg added a comment.


  In D10040#300588 <https://phabricator.kde.org/D10040#300588>, @davidedmundson \
wrote:  
  > I just removed handling of dynamically updating eisa/serialNumber it doesn't seem \
to be something that makes sense for it to change at runtime.  >
  > Also I don't want to copy the current setEdid pattern, which is broken ATM. \
Whenever any new client connects it broadcasts a change to every connected client...  \
>  I need to follow that up in another patch, possibly by making it static like these \
> two.
  
  
  Can you explain both points a bit more? Maybe when updating the Summary.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D10040

To: davidedmundson, graesslin, sebas, #kwin, dvratil
Cc: romangg, kde-frameworks-devel, davidedmundson, plasma-devel, ragreen, Pitel, \
schernikov, michaelh, ZrenBot, ngraham, bruns, alexeymin, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, eliasp, sebas, apol, mart, hein


[Attachment #3 (text/html)]

<table><tr><td style="">romangg added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D10040">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D10040#300588" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D10040#300588</a>, <a \
href="https://phabricator.kde.org/p/davidedmundson/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@davidedmundson</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>I just removed handling of dynamically \
updating eisa/serialNumber it doesn&#039;t seem to be something that makes sense for \
it to change at runtime.</p>

<p>Also I don&#039;t want to copy the current setEdid pattern, which is broken ATM. \
Whenever any new client connects it broadcasts a change to every connected \
client...<br />  I need to follow that up in another patch, possibly by making it \
static like these two.</p></div> </blockquote>

<p>Can you explain both points a bit more? Maybe when updating the \
Summary.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R127 \
KWayland</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D10040">https://phabricator.kde.org/D10040</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, graesslin, sebas, KWin, dvratil<br \
/><strong>Cc: </strong>romangg, kde-frameworks-devel, davidedmundson, plasma-devel, \
ragreen, Pitel, schernikov, michaelh, ZrenBot, ngraham, bruns, alexeymin, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]