[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D7087: Add "Copy Info" button to the About System KCM
From:       gregormi <noreply () phabricator ! kde ! org>
Date:       2018-07-15 8:55:13
Message-ID: 132c552b09272a5985e6c0c65c3d8555 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

gregormi added a comment.


  What do you think about this minor layout change? It is noticeable when the window \
is resized horizontally. Instead of centering the grid's middle line, it makes the \
left and right padding space to the window border equal which looks more pleasing at \
least to my eye.  
  Before (system installed Info Center):
  
  F6106142: grafik.png <https://phabricator.kde.org/F6106142>
  
  After (this change):
  
  F6106144: grafik.png <https://phabricator.kde.org/F6106144>
  
  New layout with spacers that push the grid columns to their minimum width:
  
  F6106150: grafik.png <https://phabricator.kde.org/F6106150>
  
  For reference: the layout in master:
  
  F6106171: grafik.png <https://phabricator.kde.org/F6106171>

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham, dhaumann, rkflx
Cc: rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ragreen, \
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">gregormi added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D7087">View Revision</a></tr></table><br \
/><div><div><p>What do you think about this minor layout change? It is noticeable \
when the window is resized horizontally. Instead of centering the grid&#039;s middle \
line, it makes the left and right padding space to the window border equal which \
looks more pleasing at least to my eye.</p>

<p>Before (system installed Info Center):</p>

<p><a href="https://phabricator.kde.org/F6106142" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">F6106142: grafik.png</a></p>

<p>After (this change):</p>

<p><a href="https://phabricator.kde.org/F6106144" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">F6106144: grafik.png</a></p>

<p>New layout with spacers that push the grid columns to their minimum width:</p>

<p><a href="https://phabricator.kde.org/F6106150" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">F6106150: grafik.png</a></p>

<p>For reference: the layout in master:</p>

<p><a href="https://phabricator.kde.org/F6106171" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">F6106171: \
grafik.png</a></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R102 \
KInfoCenter</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D7087">https://phabricator.kde.org/D7087</a></div></div><br \
/><div><strong>To: </strong>gregormi, ngraham, dhaumann, rkflx<br /><strong>Cc: \
</strong>rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, \
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, \
mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]