[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D7087: Add "Copy Info" button to the About System KCM
From:       gregormi <noreply () phabricator ! kde ! org>
Date:       2018-07-15 8:28:30
Message-ID: 1706dd8dd199dcd75fa3824aa72168d7 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

gregormi added inline comments.

INLINE COMMENTS

> rkflx wrote in Module.cpp:263
> Coming back to this after a month, I now wonder what `p` stands for, which might \
> indicate that variable could get a better name…

p stands for labelPair: renaming is a good idea. Done.

> rkflx wrote in Module.cpp:260
> I'm afraid you missed the "hidden" part, so it shows up right in front of the \
> distro logo ;) 
> Adding
> 
> dummyDistroDescriptionLabel->hide();
> 
> where you are creating the label solves the issue for me.

dummy hide: Oh sorry, I should have seen that myself. Fixed it.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham, dhaumann, rkflx
Cc: rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ragreen, \
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">gregormi added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D7087">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D7087#inline-72720">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">rkflx</span> wrote in <span style="color: \
#4b4d51; font-weight: bold;">Module.cpp:263</span></div> <div style="margin: 8px 0; \
padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Coming back to \
this after a month, I now wonder what <tt style="background: #ebebeb; font-size: \
13px;">p</tt> stands for, which might indicate that variable could get a better \
name…</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p \
style="padding: 0; margin: 8px;">p stands for labelPair: renaming is a good idea. \
Done.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D7087#inline-72718">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">rkflx</span> wrote in \
<span style="color: #4b4d51; font-weight: bold;">Module.cpp:260</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">I&#039;m afraid you missed the &quot;hidden&quot; part, so it shows up right in \
front of the distro logo ;)</p>

<p style="padding: 0; margin: 8px;">Adding</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, \
0.08);">dummyDistroDescriptionLabel-&gt;hide();</pre></div>

<p style="padding: 0; margin: 8px;">where you are creating the label solves the issue \
for me.</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p \
style="padding: 0; margin: 8px;">dummy hide: Oh sorry, I should have seen that \
myself. Fixed it.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R102 KInfoCenter</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D7087">https://phabricator.kde.org/D7087</a></div></div><br \
/><div><strong>To: </strong>gregormi, ngraham, dhaumann, rkflx<br /><strong>Cc: \
</strong>rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, \
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, \
mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]