[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D14050: Fwupd Backend For Review and Improvement
From: Abhijeet sharma <noreply () phabricator ! kde ! org>
Date: 2018-07-15 3:16:50
Message-ID: 53d606c3c3296beb2da18d8fe37a7cde () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
abhijeet2096 marked 18 inline comments as done.
abhijeet2096 added a comment.
Still, Need to implement Notification Class and some functions in Updater Class. I \
have to see if we could use the standard Updater Class, after Confirmation I will use \
directly FwupdResource instead of abstract resource
INLINE COMMENTS
> apol wrote in SourcesPage.qml:113
> Remove unrelated patch
Actually, I modified this file to show EULA on setting page.
> anthonyfieroni wrote in FwupdBackend.cpp:85
> It's memory leak.
Please see the new modified function. Will Memory be leaking?
> apol wrote in FwupdBackend.cpp:100
> No need to cast. Use the FwupdResource directly.
Still Need To Fix it
> apol wrote in FwupdNotifier.cpp:37
> Don't add one that does nothing.
> Either implement it or just don't add it.
Need to Implement it, Like Updates which require Restart. Will Implement it.
> anthonyfieroni wrote in FwupdSourcesBackend.cpp:75-77
> ?
Here, The UI gets Updates first. The CheckBox fills first then its applied at the \
backend. Need a way to control the checkbox UI
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D14050
To: abhijeet2096, apol, davidedmundson
Cc: zzag, anthonyfieroni, plasma-devel, ragreen, ixoos, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
[Attachment #3 (text/html)]
<table><tr><td style="">abhijeet2096 marked 18 inline comments as done.<br \
/>abhijeet2096 added a comment. </td><a style="text-decoration: none; padding: 4px \
8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D14050">View Revision</a></tr></table><br \
/><div><div><p>Still, Need to implement Notification Class and some functions in \
Updater Class. I have to see if we could use the standard Updater Class, after \
Confirmation I will use directly FwupdResource instead of abstract \
resource</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D14050#inline-73901">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">apol</span> wrote in <span \
style="color: #4b4d51; font-weight: bold;">SourcesPage.qml:113</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">Remove unrelated patch</p></div></div> <div style="margin: 8px 0; padding: 0 \
12px;"><p style="padding: 0; margin: 8px;">Actually, I modified this file to show \
EULA on setting page.</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D14050#inline-73888">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">anthonyfieroni</span> wrote in <span \
style="color: #4b4d51; font-weight: bold;">FwupdBackend.cpp:85</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">It's memory leak.</p></div></div> <div style="margin: 8px 0; padding: 0 \
12px;"><p style="padding: 0; margin: 8px;">Please see the new modified function. Will \
Memory be leaking?</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D14050#inline-73909">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">apol</span> wrote in <span style="color: \
#4b4d51; font-weight: bold;">FwupdBackend.cpp:100</span></div> <div style="margin: \
8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">No need \
to cast. Use the FwupdResource directly.</p></div></div> <div style="margin: 8px 0; \
padding: 0 12px;"><p style="padding: 0; margin: 8px;">Still Need To Fix \
it</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D14050#inline-73921">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">apol</span> wrote in <span \
style="color: #4b4d51; font-weight: bold;">FwupdNotifier.cpp:37</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">Don't add one that does nothing.<br /> Either implement it or just \
don't add it.</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p \
style="padding: 0; margin: 8px;">Need to Implement it, Like Updates which require \
Restart. Will Implement it.</p></div></div><br /><div style="border: 1px solid \
#C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D14050#inline-73892">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">anthonyfieroni</span> wrote in <span \
style="color: #4b4d51; font-weight: bold;">FwupdSourcesBackend.cpp:75-77</span></div> \
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; \
margin: 8px;">?</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p \
style="padding: 0; margin: 8px;">Here, The UI gets Updates first. The CheckBox fills \
first then its applied at the backend. Need a way to control the checkbox \
UI</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R134 Discover Software \
Store</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14050">https://phabricator.kde.org/D14050</a></div></div><br \
/><div><strong>To: </strong>abhijeet2096, apol, davidedmundson<br /><strong>Cc: \
</strong>zzag, anthonyfieroni, plasma-devel, ragreen, ixoos, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic