[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D14050: Fwupd Backend For Review and Improvement
From:       Abhijeet  sharma <noreply () phabricator ! kde ! org>
Date:       2018-07-15 3:06:00
Message-ID: 9f4292df0d5978f491f56a068e47c335 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

abhijeet2096 updated this revision to Diff 37778.
abhijeet2096 added a comment.


  Following Updates are made:
  
  - Removed Unnecessary Dependencies
  - Now All strings are constructed by QString
  - Regularized the indentation and coding style
  - Removed the soup headers, Now QT libs are used to Download files
  - QT based Hash Function is used to calculate Hash
  - Removed the Category File
  - Removed The Review Backend Completely
  - Added Dependencies of soup, glib and GIO inside FINDLIBFWUPD.cmake
  - QUrl and QFile is Now Used
  - Added Checks at Various Places

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14050?vs=37580&id=37778

REVISION DETAIL
  https://phabricator.kde.org/D14050

AFFECTED FILES
  CMakeLists.txt
  cmake/FindGIO.cmake
  cmake/FindGLib.cmake
  cmake/FindGObject.cmake
  cmake/FindGObjectIntrospection.cmake
  cmake/FindLIBFWUPD.cmake
  cmake/FindSoup.cmake
  discover/qml/SourcesPage.qml
  libdiscover/backends/CMakeLists.txt
  libdiscover/backends/FwupdBackend/CMakeLists.txt
  libdiscover/backends/FwupdBackend/FwupdBackend.cpp
  libdiscover/backends/FwupdBackend/FwupdBackend.h
  libdiscover/backends/FwupdBackend/FwupdNotifier.cpp
  libdiscover/backends/FwupdBackend/FwupdNotifier.h
  libdiscover/backends/FwupdBackend/FwupdResource.cpp
  libdiscover/backends/FwupdBackend/FwupdResource.h
  libdiscover/backends/FwupdBackend/FwupdSourcesBackend.cpp
  libdiscover/backends/FwupdBackend/FwupdSourcesBackend.h
  libdiscover/backends/FwupdBackend/FwupdTransaction.cpp
  libdiscover/backends/FwupdBackend/FwupdTransaction.h
  libdiscover/backends/FwupdBackend/FwupdUpdater.cpp
  libdiscover/backends/FwupdBackend/FwupdUpdater.h
  libdiscover/backends/FwupdBackend/tests/CMakeLists.txt
  libdiscover/backends/FwupdBackend/tests/FwupdTest.cpp
  libdiscover/backends/FwupdBackend/tests/FwupdTest.h
  libdiscover/backends/FwupdBackend/tests/UpdateFwupdTest.cpp
  libdiscover/resources/AbstractSourcesBackend.h

To: abhijeet2096, apol, davidedmundson
Cc: zzag, anthonyfieroni, plasma-devel, ragreen, ixoos, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">abhijeet2096 updated this revision to Diff 37778.<br \
/>abhijeet2096 added a comment. </td><a style="text-decoration: none; padding: 4px \
8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D14050">View Revision</a></tr></table><br \
/><div><div><p>Following Updates are made:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">Removed Unnecessary Dependencies</li>
<li class="remarkup-list-item">Now All strings are constructed by QString</li>
<li class="remarkup-list-item">Regularized the indentation and coding style</li>
<li class="remarkup-list-item">Removed the soup headers, Now QT libs are used to \
Download files</li> <li class="remarkup-list-item">QT based Hash Function is used to \
calculate Hash</li> <li class="remarkup-list-item">Removed the Category File</li>
<li class="remarkup-list-item">Removed The Review Backend Completely</li>
<li class="remarkup-list-item">Added Dependencies of soup, glib and GIO inside \
FINDLIBFWUPD.cmake</li> <li class="remarkup-list-item">QUrl and QFile is Now \
Used</li> <li class="remarkup-list-item">Added Checks at Various Places</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R134 Discover \
Software Store</div></div></div><br /><div><strong>CHANGES SINCE LAST \
UPDATE</strong><div><a \
href="https://phabricator.kde.org/D14050?vs=37580&amp;id=37778">https://phabricator.kde.org/D14050?vs=37580&amp;id=37778</a></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14050">https://phabricator.kde.org/D14050</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br /> \
cmake/FindGIO.cmake<br /> cmake/FindGLib.cmake<br />
cmake/FindGObject.cmake<br />
cmake/FindGObjectIntrospection.cmake<br />
cmake/FindLIBFWUPD.cmake<br />
cmake/FindSoup.cmake<br />
discover/qml/SourcesPage.qml<br />
libdiscover/backends/CMakeLists.txt<br />
libdiscover/backends/FwupdBackend/CMakeLists.txt<br />
libdiscover/backends/FwupdBackend/FwupdBackend.cpp<br />
libdiscover/backends/FwupdBackend/FwupdBackend.h<br />
libdiscover/backends/FwupdBackend/FwupdNotifier.cpp<br />
libdiscover/backends/FwupdBackend/FwupdNotifier.h<br />
libdiscover/backends/FwupdBackend/FwupdResource.cpp<br />
libdiscover/backends/FwupdBackend/FwupdResource.h<br />
libdiscover/backends/FwupdBackend/FwupdSourcesBackend.cpp<br />
libdiscover/backends/FwupdBackend/FwupdSourcesBackend.h<br />
libdiscover/backends/FwupdBackend/FwupdTransaction.cpp<br />
libdiscover/backends/FwupdBackend/FwupdTransaction.h<br />
libdiscover/backends/FwupdBackend/FwupdUpdater.cpp<br />
libdiscover/backends/FwupdBackend/FwupdUpdater.h<br />
libdiscover/backends/FwupdBackend/tests/CMakeLists.txt<br />
libdiscover/backends/FwupdBackend/tests/FwupdTest.cpp<br />
libdiscover/backends/FwupdBackend/tests/FwupdTest.h<br />
libdiscover/backends/FwupdBackend/tests/UpdateFwupdTest.cpp<br />
libdiscover/resources/AbstractSourcesBackend.h</div></div></div><br \
/><div><strong>To: </strong>abhijeet2096, apol, davidedmundson<br /><strong>Cc: \
</strong>zzag, anthonyfieroni, plasma-devel, ragreen, ixoos, Pitel, ZrenBot, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]