[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D7087: Add "Copy Info" button to the About System KCM
From:       gregormi <noreply () phabricator ! kde ! org>
Date:       2018-06-29 15:57:13
Message-ID: d84bc12914fa9f41eefc97e36fb90c6c () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

gregormi marked 6 inline comments as done.
gregormi added inline comments.

INLINE COMMENTS

> rkflx wrote in Module.cpp:260
> Maybe you could avoid this special case if you added a hidden label in \
> `loadSoftware`? 
> Also, "label in … the button" sounds a bit odd. Perhaps "label" would be enough, \
> or use `@title:row`? (See https://api.kde.org/frameworks/ki18n/html/prg_guide.html)

Good idea. DONE.

> rkflx wrote in Module.ui:349-351
> Works perfectly fine for me. I think there might be something off with your local \
> shortcuts setup.

Ok. Then I leave it like that.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham, dhaumann, rkflx
Cc: rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ragreen, \
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">gregormi marked 6 inline comments as done.<br />gregormi \
added inline comments. </td><a style="text-decoration: none; padding: 4px 8px; \
margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: \
3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D7087">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D7087#inline-69157">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">rkflx</span> wrote in <span style="color: \
#4b4d51; font-weight: bold;">Module.cpp:260</span></div> <div style="margin: 8px 0; \
padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Maybe you could \
avoid this special case if you added a hidden label in <tt style="background: \
#ebebeb; font-size: 13px;">loadSoftware</tt>?</p>

<p style="padding: 0; margin: 8px;">Also, &quot;label in … the button&quot; sounds \
a bit odd. Perhaps &quot;label&quot; would be enough, or use <tt style="background: \
#ebebeb; font-size: 13px;">@title:row</tt>? (See <a \
href="https://api.kde.org/frameworks/ki18n/html/prg_guide.html" class="remarkup-link" \
target="_blank" rel="noreferrer">https://api.kde.org/frameworks/ki18n/html/prg_guide.html</a>)</p></div></div>
 <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Good idea. DONE.</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D7087#inline-69151">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">rkflx</span> wrote in <span style="color: \
#4b4d51; font-weight: bold;">Module.ui:349-351</span></div> <div style="margin: 8px \
0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Works \
perfectly fine for me. I think there might be something off with your local shortcuts \
setup.</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p \
style="padding: 0; margin: 8px;">Ok. Then I leave it like \
that.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R102 KInfoCenter</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D7087">https://phabricator.kde.org/D7087</a></div></div><br \
/><div><strong>To: </strong>gregormi, ngraham, dhaumann, rkflx<br /><strong>Cc: \
</strong>rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, \
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, \
mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]