[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D7087: Add "Copy Info" button to the About System KCM
From:       gregormi <noreply () phabricator ! kde ! org>
Date:       2018-06-29 15:53:23
Message-ID: 98e11104dba97a2ff923ea8c888581d8 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

gregormi updated this revision to Diff 36893.
gregormi added a comment.


  - Rework the Module.ui layout to fix the spacing
  - Add dummy label to remove special case for "Distro"
  - Use C++11 for loop and add qAsConst
  - Make RTL aware by not removing the colon
  - Improve translation context message

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7087?vs=35167&id=36893

BRANCH
  arcpatch-D7087_1

REVISION DETAIL
  https://phabricator.kde.org/D7087

AFFECTED FILES
  Modules/about-distro/src/Module.cpp
  Modules/about-distro/src/Module.h
  Modules/about-distro/src/Module.ui

To: gregormi, ngraham, dhaumann, rkflx
Cc: rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ragreen, \
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">gregormi updated this revision to Diff 36893.<br />gregormi \
added a comment. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 \
8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D7087">View Revision</a></tr></table><br \
/><div><div><ul class="remarkup-list"> <li class="remarkup-list-item">Rework the \
Module.ui layout to fix the spacing</li> <li class="remarkup-list-item">Add dummy \
label to remove special case for &quot;Distro&quot;</li> <li \
class="remarkup-list-item">Use C++11 for loop and add qAsConst</li> <li \
class="remarkup-list-item">Make RTL aware by not removing the colon</li> <li \
class="remarkup-list-item">Improve translation context message</li> \
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R102 \
KInfoCenter</div></div></div><br /><div><strong>CHANGES SINCE LAST \
UPDATE</strong><div><a \
href="https://phabricator.kde.org/D7087?vs=35167&amp;id=36893">https://phabricator.kde.org/D7087?vs=35167&amp;id=36893</a></div></div><br \
/><div><strong>BRANCH</strong><div><div>arcpatch-D7087_1</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D7087">https://phabricator.kde.org/D7087</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>Modules/about-distro/src/Module.cpp<br /> \
Modules/about-distro/src/Module.h<br /> \
Modules/about-distro/src/Module.ui</div></div></div><br /><div><strong>To: \
</strong>gregormi, ngraham, dhaumann, rkflx<br /><strong>Cc: </strong>rkflx, \
dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ragreen, Pitel, \
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]