[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13774: [QDBusMenuBar] Guard m_window with a QPointer
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2018-06-28 9:45:11
Message-ID: a0292764c6982d9a3e7c07aa1aa3a6d2 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  In reviewing I found a quirky bit of code:
  
    void QDBusMenuBar::handleReparent(QWindow *newParentWindow)
    {
        if (newParentWindow && newParentWindow != m_window) {
            m_window = newParentWindow
  
  if we ever got handleReparent with a nullptr, we wouldn't update our m_window. \
Could this be the root cause?

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D13774

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">davidedmundson accepted this revision.<br />davidedmundson \
added a comment.<br />This revision is now accepted and ready to land. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13774">View \
Revision</a></tr></table><br /><div><div><p>In reviewing I found a quirky bit of \
code:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">void \
QDBusMenuBar::handleReparent(QWindow *newParentWindow) {
    if (newParentWindow &amp;&amp; newParentWindow != m_window) {
        m_window = newParentWindow</pre></div>

<p>if we ever got handleReparent with a nullptr, we wouldn&#039;t update our \
m_window. Could this be the root cause?</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R135 Integration for Qt applications in \
Plasma</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13774">https://phabricator.kde.org/D13774</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, davidedmundson<br /><strong>Cc: \
</strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]