[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13774: [QDBusMenuBar] Guard m_window with a QPointer
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2018-06-28 6:33:03
Message-ID: 25695fbc0dd8e9ad449740b737b3a115 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

broulik created this revision.
broulik added reviewers: Plasma, davidbekham.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It can be deleted without us knowing for MDI windows as happens in QtCurve config.
  
  BUG: 376340
  FIXED-IN: 5.12.7

TEST PLAN
  - Can open QtCurve config dialog without crashing
  - The MDI's window becomes attached to the actual window it is contained within but \
it's still better than a crash

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D13774

AFFECTED FILES
  src/platformtheme/qdbusmenubar_p.h

To: broulik, #plasma, davidbekham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">broulik created this revision.<br />broulik added reviewers: \
Plasma, davidbekham.<br />Restricted Application added a project: Plasma.<br \
/>Restricted Application added a subscriber: plasma-devel.<br />broulik requested \
review of this revision. </td><a style="text-decoration: none; padding: 4px 8px; \
margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: \
3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13774">View Revision</a></tr></table><br \
/><div><strong>REVISION SUMMARY</strong><div><p>It can be deleted without us knowing \
for MDI windows as happens in QtCurve config.</p>

<p>BUG: 376340<br />
FIXED-IN: 5.12.7</p></div></div><br /><div><strong>TEST PLAN</strong><div><ul \
class="remarkup-list"> <li class="remarkup-list-item">Can open QtCurve config dialog \
without crashing</li> <li class="remarkup-list-item">The MDI&#039;s window becomes \
attached to the actual window it is contained within but it&#039;s still better than \
a crash</li> </ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R135 \
Integration for Qt applications in Plasma</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13774">https://phabricator.kde.org/D13774</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>src/platformtheme/qdbusmenubar_p.h</div></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, davidbekham<br /><strong>Cc: \
</strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]